From: Alex Kost <alezost@gmail.com>
To: Kei Yamashita <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add MilkyTracker to Guix
Date: Wed, 30 Mar 2016 23:52:04 +0300 [thread overview]
Message-ID: <877fgjy9hn.fsf@gmail.com> (raw)
In-Reply-To: <20160329222441.12a28061@openmailbox.org> (Kei Yamashita's message of "Tue, 29 Mar 2016 22:24:41 -0400")
Kei Yamashita (2016-03-30 05:24 +0300) wrote:
> Alright! This patch adds MilkyTracker successfully. It builds with
> both ALSA and JACK support. I took a look at the PKGBUILD from Arch
> Linux and the port dependencies from FreeBSD to make sure I had
> everything in order. Hopefully it is clean as far as syntax and guix
> standards go.
Great! Thank you for fixing the build process! I have only 4 small
comments:
1) Your previous patches contained:
+ #:use-module (gnu packages sdl)
But it is removed in this one. I think it was done by mistake when you
removed the leftovers of other commits.
> If you could show me how you managed to get guix lint to
> run on this file, that would be great.
As Leo pointed, you can use "pre-inst-env" script to run guix tools from
a git checkout. See (info "(guix) Running Guix Before It Is Installed")
for details.
> From e3a393da0ee6d0a22d4077a6f83601a8a246def3 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Tue, 29 Mar 2016 22:17:21 -0400
> Subject: [PATCH] gnu: Add MilkyTracker.
>
> * gnu/packages/music.scm (milkytracker): New variable.
> ---
> gnu/packages/music.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index adda16a..9794c17 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1306,3 +1306,33 @@ once and for all. It catalogs your collection, automatically improving its
> metadata as it goes using the MusicBrainz database. Then it provides a variety
> of tools for manipulating and accessing your music.")
> (license license:expat)))
> +
> +(define-public milkytracker
> + (package
> + (name "milkytracker")
> + (version "0.90.86")
> + (source (origin
> + (method url-fetch)
^^^^
2) tabulation on this line
> + (uri (string-append "http://milkytracker.org/files/"
> + name "-" version ".tar.bz2"))
> +
^^^^^^^^^^^^^^
3) this redundant line
> + (sha256
> + (base32
> + "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:make-flags '("CXXFLAGS=-lasound")))
> + (inputs
> + `(("alsa-lib" ,alsa-lib)
> + ("jack" ,jack-1)
> + ("sdl" ,sdl)
> + ("zlib" ,zlib)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (synopsis "Music tracker for working with .MOD/.XM module files")
> + (description "MilkyTracker is a music application for creating .MOD and .XM
> +module files. It attempts to recreate the module replay and user experience of
> +the popular DOS program Fasttracker II, with special playback modes available
> +for improved Amiga ProTracker 2/3 compatibility.")
> + (home-page "http://milkytracker.org/")
> + (license license:gpl3)))
4) I looked closer at the licenses. It appeared to be that the code in
"src/milkyplay" is under Modified BSD (bsd-3), and the rest is under
GPL3 or later (gl3+).
The rest looks good to me, so I adjusted your patch for the mentioned
notes and committed it¹. Oh, also I added a copyright line with your
name to the beginning of the file. Thanks for contributing!
¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=21d1811301c4acc34dc124c832d21918c2d11a95
--
Alex
next prev parent reply other threads:[~2016-03-30 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 23:54 [PATCH] Add MilkyTracker to Guix kei
2016-03-26 10:11 ` Nils Gillmann
2016-03-27 7:23 ` Efraim Flashner
2016-03-28 3:09 ` Kei Yamashita
2016-03-28 10:46 ` Alex Kost
2016-03-28 14:26 ` Ricardo Wurmus
2016-03-28 17:30 ` Kei Yamashita
2016-03-28 17:39 ` Kei Yamashita
2016-03-28 17:43 ` Kei Yamashita
2016-03-28 19:31 ` Kei Yamashita
2016-03-29 9:52 ` Alex Kost
2016-03-30 2:24 ` Kei Yamashita
2016-03-30 2:36 ` Leo Famulari
2016-03-30 20:52 ` Alex Kost [this message]
2016-03-27 14:17 ` Nils Gillmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fgjy9hn.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.