From: Alex Kost <alezost@gmail.com>
To: Jelle Licht <jlicht@fsfe.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] Add oniguruma
Date: Fri, 01 Apr 2016 11:59:01 +0300 [thread overview]
Message-ID: <877fgh66y2.fsf@gmail.com> (raw)
In-Reply-To: <CAPsKtfJdaMREKaWhoFBhAPsu1bM9N1+oDARkok4s9WgM_QoCng@mail.gmail.com> (Jelle Licht's message of "Sat, 26 Mar 2016 18:40:29 +0100")
Jelle Licht (2016-03-26 20:40 +0300) wrote:
> Hello guix!
Hi and welcome!
> I packaged my first set of guix packages, following the guidelines
> mentioned in the online manual as closely as I could. If I still
> forgot or misinterpreted one of the steps, some pointers are always
> welcome.
Great, thanks! The only nitpick is that we use periods in the commit
messages: "gnu: Add oniguruma." and "... New variable."
> From 1748b97890d0fc90e81c0e0a302c7e55562873d3 Mon Sep 17 00:00:00 2001
> From: Jelle Licht <jlicht@fsfe.org>
> Date: Sat, 26 Mar 2016 18:28:31 +0100
> Subject: [PATCH 1/2] gnu: Add oniguruma
>
> * gnu/packages/textutils.scm (oniguruma): New variable
> ---
> gnu/packages/textutils.scm | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
Applied.
--
Alex
prev parent reply other threads:[~2016-04-01 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 17:40 [PATCH 1/2] Add oniguruma Jelle Licht
2016-04-01 8:59 ` Alex Kost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fgh66y2.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.