From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [v2 1/2] gnu: Add libbsd. Date: Sat, 02 Apr 2016 10:47:14 +0300 Message-ID: <877fgga1vh.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amGHB-0000X5-BE for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amGH6-0006nR-9q for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:21 -0400 Received: from mail-lb0-x231.google.com ([2a00:1450:4010:c04::231]:34546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amGH6-0006n4-1T for guix-devel@gnu.org; Sat, 02 Apr 2016 03:47:16 -0400 Received: by mail-lb0-x231.google.com with SMTP id vo2so90822150lbb.1 for ; Sat, 02 Apr 2016 00:47:15 -0700 (PDT) In-Reply-To: (Leo Famulari's message of "Fri, 1 Apr 2016 21:24:33 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari (2016-04-02 04:24 +0300) wrote: > * gnu/packages/libbsd.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > --- > gnu-system.am | 1 + > gnu/packages/libbsd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+) > create mode 100644 gnu/packages/libbsd.scm [...] > +(define-public libbsd > + (package > + (name "libbsd") > + (version "0.8.2") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://libbsd.freedesktop.org/releases/" > + "libbsd-" version ".tar.xz")) > + (sha256 > + (base32 > + "02i5brb2007sxq3mn862mr7yxxm0g6nj172417hjyvjax7549xmj")))) > + (build-system gnu-build-system) > + (synopsis "Utility functions from BSD systems") > + (description "This library provides useful functions commonly found on BSD > +systems, and lacking on others like GNU systems, thus making it easier to port > +projects with strong BSD origins, without needing to embed the same code over > +and over again on each project.") > + (home-page "https://libbsd.freedesktop.org/wiki/") > + (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain non-copyleft)))) Wow, a lot of licenses! "guix lint" reports: "invalid license field". This happens because 'non-copyleft' is a procedure, not a license. Look at other packages to see how it is used. Also, please don't make such long lines. Overall it would be something like this: (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain (non-copyleft "file://COPYING" "See COPYING in the distribution."))) The rest looks good to me, thanks! -- Alex