From: Alex Kost <alezost@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [v2 1/2] gnu: Add libbsd.
Date: Sat, 02 Apr 2016 10:47:14 +0300 [thread overview]
Message-ID: <877fgga1vh.fsf@gmail.com> (raw)
In-Reply-To: <dc7419fdd118dce1be529e07131a77879985f396.1459560195.git.leo@famulari.name> (Leo Famulari's message of "Fri, 1 Apr 2016 21:24:33 -0400")
Leo Famulari (2016-04-02 04:24 +0300) wrote:
> * gnu/packages/libbsd.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
> gnu-system.am | 1 +
> gnu/packages/libbsd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 gnu/packages/libbsd.scm
[...]
> +(define-public libbsd
> + (package
> + (name "libbsd")
> + (version "0.8.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://libbsd.freedesktop.org/releases/"
> + "libbsd-" version ".tar.xz"))
> + (sha256
> + (base32
> + "02i5brb2007sxq3mn862mr7yxxm0g6nj172417hjyvjax7549xmj"))))
> + (build-system gnu-build-system)
> + (synopsis "Utility functions from BSD systems")
> + (description "This library provides useful functions commonly found on BSD
> +systems, and lacking on others like GNU systems, thus making it easier to port
> +projects with strong BSD origins, without needing to embed the same code over
> +and over again on each project.")
> + (home-page "https://libbsd.freedesktop.org/wiki/")
> + (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain non-copyleft))))
Wow, a lot of licenses! "guix lint" reports: "invalid license field".
This happens because 'non-copyleft' is a procedure, not a license. Look
at other packages to see how it is used. Also, please don't make such
long lines. Overall it would be something like this:
(license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain
(non-copyleft "file://COPYING"
"See COPYING in the distribution.")))
The rest looks good to me, thanks!
--
Alex
next prev parent reply other threads:[~2016-04-02 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 1:24 [v2 0/2] Signify Leo Famulari
2016-04-02 1:24 ` [v2 1/2] gnu: Add libbsd Leo Famulari
2016-04-02 7:47 ` Alex Kost [this message]
2016-04-02 17:21 ` Leo Famulari
2016-04-02 1:24 ` [v2 2/2] gnu: Add signify Leo Famulari
2016-04-02 7:47 ` Alex Kost
2016-04-02 17:22 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fgga1vh.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.