From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: Add libbsd.
Date: Thu, 07 Apr 2016 23:19:24 +0200
Message-ID: <877fg99kwz.fsf@gnu.org>
References: <cover.1459033650.git.leo@famulari.name>
	<cover.1459033650.git.leo@famulari.name>
	<e048784586c8a37391b9f2499bc77a44138e3af7.1459033650.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aoHKs-0002Cz-QC
	for guix-devel@gnu.org; Thu, 07 Apr 2016 17:19:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aoHKp-0003eW-JI
	for guix-devel@gnu.org; Thu, 07 Apr 2016 17:19:30 -0400
In-Reply-To: <e048784586c8a37391b9f2499bc77a44138e3af7.1459033650.git.leo@famulari.name>
	(Leo Famulari's message of "Sat, 26 Mar 2016 19:18:59 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/libbsd.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

I lost track of the discussion, but it=E2=80=99d be sad if simple packages =
like
this were stuck in review forever.  :-)

In general, for simple additions like this, consider yourself entitled
to push after some time has passed, as noted in =E2=80=98HACKING=E2=80=99.

[...]

> +(define-public libbsd
> +  (package
> +    (name "libbsd")
> +    (version "0.8.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://libbsd.freedesktop.org/releas=
es/"
> +                                  "libbsd-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "02i5brb2007sxq3mn862mr7yxxm0g6nj172417hjyvjax7549xmj"))=
))
> +    (build-system gnu-build-system)
> +    (synopsis "Utility functions from BSD systems")
> +    (description "This library provides useful functions commonly found =
on BSD
> +systems, and lacking on others like GNU systems, thus making it easier t=
o port
> +projects with strong BSD origins, without needing to embed the same code=
 over
> +and over again on each project.")
> +    (home-page "https://libbsd.freedesktop.org/wiki/")
> +    (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain))=
))

Please mention in a comment above what this license list means: is it at
the user=E2=80=99s choice, a mixture of all, etc.  Note that =E2=80=98bsd-s=
tyle=E2=80=99 is a
procedure, and is deprecated (=E2=80=98guix lint=E2=80=99 should warn.)

Otherwise LGTM, thanks!

Ludo=E2=80=99.