From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 8/8] services: Add spice vdagent service.
Date: Sun, 31 Jul 2016 00:41:08 +0200
Message-ID: <877fc2agvv.fsf@gnu.org>
References: <20160729082357.17501-1-david@craven.ch>
	<20160729082357.17501-8-david@craven.ch> <87r3acxnj9.fsf@gnu.org>
	<CAL1_imkg7eiJ-CS802pP9s9Jnw8Tm4vQbtEunrPEdbiMoBw66A@mail.gmail.com>
	<CAL1_imm7_cWoRpAL8tJErgOjV6ph3TT1JQYXd+GqS8_b1Oia-w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTcwX-0000xa-SN
	for guix-devel@gnu.org; Sat, 30 Jul 2016 18:41:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTcwS-0006Dt-42
	for guix-devel@gnu.org; Sat, 30 Jul 2016 18:41:16 -0400
In-Reply-To: <CAL1_imm7_cWoRpAL8tJErgOjV6ph3TT1JQYXd+GqS8_b1Oia-w@mail.gmail.com>
	(David Craven's message of "Sat, 30 Jul 2016 12:29:34 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>

David Craven <david@craven.ch> skribis:

>> If spice-vdagend produces a PID file, make sure to use #:pid-file here
>> (there are several examples in the tree), which often provides more
>> reliable startup notification.
>
> I'm passing the -x flag which prevents spice-vdagentd from
> daemonizing. I thought that make-forkexec-constructor took care of
> setting the correct stdout stderr stdin user process-parent and pid
> file automatically. Is that not the way it's intended to be used?

It is, but it can also wait until a PID file is created:

  https://www.gnu.org/software/shepherd/manual/html_node/Service-De_002d-an=
d-Constructors.html

HTH!

Ludo=E2=80=99.