From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 07/11] gnu: ncurses: support mingw.
Date: Wed, 10 Aug 2016 14:04:51 -0400
Message-ID: <877fbowldo.fsf@netris.org>
References: <20160809064139.27872-1-janneke@gnu.org>
	<20160809064139.27872-8-janneke@gnu.org> <87mvkmcr9k.fsf@gmail.com>
	<8737mevspt.fsf@gnu.org> <8737mcc34h.fsf@gmail.com>
	<87k2fovkim.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bXXsJ-0001A7-HH
	for guix-devel@gnu.org; Wed, 10 Aug 2016 14:05:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bXXsG-0006ZQ-8k
	for guix-devel@gnu.org; Wed, 10 Aug 2016 14:05:07 -0400
In-Reply-To: <87k2fovkim.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 10
	Aug 2016 15:08:49 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>

Jan Nieuwenhuizen <janneke@gnu.org> writes:

> Hmm...the patch removes the duplication, it also rebuilds everything of
> course.  Would this be the way to do it, would we want to have this in
> core-updates or is there a better way?

Even just modifying the existing 'ncurses' derivations will force ~10000
rebuilds, which is far too much outside of core-updates.

In theory, it should be possible to arrange for the 'ncurses'
derivations to be unchanged when not targetting mingw, by doing these
tests on the client side instead of the build side.  Remember that these
backquoted excerpts of code are being generated on the client side to be
run later on the build side, so we should be able to arrange for this
generated code to be unchanged except on mingw.  However, dealing with
the patch will be a bit ugly.  The job of modifying curses.h.in would
have to be moved to a phase.

I'll try to find time in the next day or two to attempt this, and see if
it can be done reasonably or if the resulting code would be too nasty to
consider.

Thanks for working on this.

      Mark