Re: [PATCH]: opensmtpd, opensmtpd-extras, libasr.

[ng0 <ng0@we.make.ritual.n0.is>]

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@n0.is> writes:
>
>> From 30c8260a039d4c8d7cddbfd92341afa65577d680 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@we.make.ritual.n0.is>
>> Date: Tue, 6 Sep 2016 17:10:18 +0000
>> Subject: [PATCH 1/3] gnu: Add libasr.
>>
>> * gnu/packages/web.scm (libasr): New variable.
>
> Nice!
>
>> ---
>>  gnu/packages/web.scm | 33 +++++++++++++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>
> From reading the description below, should this not go in dns.scm?

That's what I thought too, and I agree.

>> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
>> index 70bfd9e..59ae049 100644
>> --- a/gnu/packages/web.scm
>> +++ b/gnu/packages/web.scm
>> @@ -61,6 +61,7 @@
>>    #:use-module (gnu packages gnome)
>>    #:use-module (gnu packages gperf)
>>    #:use-module (gnu packages gtk)
>> +  #:use-module (gnu packages groff)
>>    #:use-module (gnu packages icu4c)
>>    #:use-module (gnu packages image)
>>    #:use-module (gnu packages lua)
>> @@ -3609,3 +3610,35 @@ tools they trust (e.g. wget).")
>>  rendering engine entirely written from scratch.  It is small and capable of
>>  handling many of the web standards in use today.")
>>      (license l:gpl2+)))
>> +
>> +(define-public libasr
>> +  (package
>> +    (name "libasr")
>> +    (version "201602131606")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://www.opensmtpd.org/archives/"
>> +                           name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "18kdmbjsxrfai16d66qslp48b1zf7gr8him2jj5dcqgbsl44ls75"))))
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("pkg-config" ,pkg-config)
>> +       ("groff" ,groff)))
>> +    (home-page "https://www.opensmtpd.org")
>> +    (synopsis "Asynchronous resolver library by the OpenBSD project")
>> +    (description
>> +     "libasr is a free, simple and portable asynchronous resolver library.
>> +It allows to run dns queries and perform hostname resolutions in a fully
>                     ^^^
>                     Please capitalize.
>
>> +asynchronous fashion.  The implementation is thread-less, fork-less, and
>> +does not make use of signals or other 'tricks' that might get in the
>> +developer's way.")
>
> The second sentence may be left off, IMO.

I agree.

>> +    (license (list l:isc
>> +                   l:bsd-2 ; last part of getrrsetbyname_async.c
>> +                   l:bsd-3
>> +                   (l:non-copyleft "file://COPYING") ; includes.h
>
> This should probably be "file://LICENSE".
>
>> +                   l:openssl))))
>
> Why is OpenSSL listed? Grepping for 'openssl' returns no results.

I'm not exactly sure, their COPYING listed 2 licenses I could not figure
out, one of them was openssl I think. If you think there's no openssl
license, I'll remove it.

> The rest of this patch LGTM. I won't comment on the other two as I don't
> know enough about how paths and user accounts is usually handled.
>
> Cheers,
> Marius
>

Thanks for reviewing.
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org