Re: [PATCH] doc: Add information related to network connectivity with qemu.

[ludo@gnu.org (Ludovic Courtès)]

Hello!

David Craven <david@craven.ch> skribis:

> * doc/guix.text: Add it.

Could you mention the sections modified/added?  See
c8b543741f422ecf41e7635c6a1c40b3bd55947a for an example.

I only have cosmetic suggestions:

> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -11030,6 +11030,45 @@ which may be insufficient for some operations.
>  The file name of the qcow2 image.
>  @end table
>  
> +The default @command{run-vm.sh} script that is returned by an invokation of
> +@command{guix system vm} does not add a @command{-net user} flag by default.
> +To get network access from within the vm add the @code{(dhcp-client-service)}
> +to your system definition and start the vm using

s/vm/VM/

> +@command{$(guix system vm config.scm) -net user}.  An important caveat of using

I tend to use backquotes instead of $(…) in shell examples, for the sake
of people who do not use Bash or a compatible shell.

> +@command{-net user} for networking is that @command{ping} will not work, because
> +it uses the ICMP protocol.  You'll have to use a different command to check for
> +network connectivity, I'll leave this as an exercise for the reader.
> +
> +@subsubsection Connecting through ssh

“Connecting Through SSH”

> +To enable ssh inside a vm you need to add a ssh server like @code{(dropbear-service)}
> +or @code{(lsh-service)} to your vm. The @code{(lsh-service}) doesn't currently
> +boot unsupervised. It requires you to type some characters to initialize the
> +randomness generator. In addition you need to forward the ssh port, 22 by
> +default, to the host. You can do this with
> +@command{$(guix system vm config.scm) -net user,hostfwd=tcp::10022-:22}. To connect
> +to the vm you can run
> +@command{ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 10022}.
> +The @command{-p} tells @command{ssh} the port you want to connect to.
> +@command{-o UserKnownHostsFile=/dev/null} prevents @command{ssh} from complaining
> +every time you modify your @command{config.scm} file and the
> +@command{-o StrictHostKeyChecking=no} prevents you from having to allow a
> +connection to an unknown host every time you connect.

s/ssh/SSH/ (when referring to the protocol), and s/vm/VM/, and
two-spaces-after-period please.  :-)

When giving a non-trivial command, it might be worth putting it in
@example so that it stands out more clearly:

  You can do this with:

  @example
  `guix system vm config.scm` -net user,hostfwd=tcp::10022-:22
  @end example

Also, might be worth adding “(@pxref{Networking Services})” at the end
of the first sentence above.

> +@subsubsection Using virt-viewer with spice

“Using @command{virt-viewer} with Spice”

> +The default qemu graphical client isn't very nice.  As an alternative you can

s/qemu/QEMU/

Also maybe replace “isn’t very nice” by “is limited in such and such
way”, or “lacks the ability to do foo and bar”.  (I’m actually genuinely
interested in knowing what Spice provides compared to the built-in
client, having not used it yet.  :-))

> +use the @command{remote-viewer} from the @command{virt-viewer} package. To
> +connect pass the @command{-spice port=5930,disable-ticketing} flag to
> +@command{qemu}. See previous section for further information on how to do this.
> +
> +Spice also allows you to do some nice stuff like share your clipboard with your
> +vm.  To enable that you'll have to in addition pass the following flags to
> +@command{qemu}: @command{-device virtio-serial-pci,id=virtio-serial0,max_ports=16,bus=pci.0,addr=0x5}
> +@command{-chardev spicevmc,name=vdagent,id=vdagent}
> +@command{-device virtserialport,nr=1,bus=virtio-serial0.0,chardev=vdagent,name=com.redhat.spice.0}.
> +You'll also need to add the @code{(spice-vdagent-service)}.

(@pxref{Miscellaneous Services, Spice service})

It’s a great addition, thank you!

Ludo’.