all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add supertuxkart.
Date: Sun, 23 Oct 2016 15:11:59 +0200	[thread overview]
Message-ID: <877f8zw6ow.fsf@elephly.net> (raw)
In-Reply-To: <87oa2hltci.fsf@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/games.scm (supertuxkart): New variable.
>
> Woohoo!
>
>> +       (snippet
>> +        ;; Delete bundled library sources
>> +        '(begin
>> +           ;; FIXME: try to unbundle enet, and angelscript
>> +           (for-each delete-file-recursively
>> +                     '("lib/zlib"
>> +                       "lib/libpng"
>> +                       "lib/jpeglib"
>> +                       "lib/glew"
>> +                       "lib/wiiuse"))
>> +           #t))))
>
> [...]
>
>> +             (substitute* "CMakeLists.txt"
>> +               ;; Supertuxkart uses modified versions of the Irrlicht engine
>> +               ;; and the bullet library.  The developers gave an explanation here:
>> +               ;; http://forum.freegamedev.net/viewtopic.php?f=17&t=3906
>> +               (("add_subdirectory\\(.*/(glew|zlib)\"\\)") "")
>
> I think this clause should go to the snippet above.

I moved it to the snippet and pushed as
1a0633e79b83d9ee740a83f29c05b86e9558da00.

Thanks!

~~ Ricardo

      reply	other threads:[~2016-10-23 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 21:37 [PATCH] gnu: Add supertuxkart Ricardo Wurmus
2016-10-18 12:44 ` Ludovic Courtès
2016-10-23 13:11   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f8zw6ow.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.