From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello. Date: Thu, 27 Oct 2016 10:31:13 +0200 Message-ID: <877f8udwha.fsf@gnu.org> References: <87oa2887b1.fsf@gnu.org> <87bmy8glwz.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzg4W-00076O-H6 for guix-devel@gnu.org; Thu, 27 Oct 2016 04:30:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzg4T-0000JW-CN for guix-devel@gnu.org; Thu, 27 Oct 2016 04:30:00 -0400 In-reply-to: <87bmy8glwz.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > Hi Roel, > > funny, this has also been on my pile of unsubmitted, bit-rotting patches > (because I must use Trello at work and I much rather use org-mode). I > remember that this wasn’t straight-forward to package and required a lot > more (build-time) inputs. We seem to have quite some overlap between our packages and preference for the software programs we want to use. :) > The cask file says: > > (development > (depends-on "dash-functional") > (depends-on "dash") @code{dash} provides @code{dash-functional}. > (depends-on "undercover") This one is needed to run the tests. > (depends-on "ert-runner") > (depends-on "ert") > (depends-on "ert-expectations") These should be built-in. See: https://www.gnu.org/software/emacs/manual/html_node/ert/ (Or M-x ert) > (depends-on "el-mock") > (depends-on "helm")) These should be added too, to run the tests. I added undercover, el-mock and helm to the inputs. >> * gnu/packages/emacs.scm (emacs-org-trello): New variable. >> --- >> gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index 69fd10f..964ba59 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -2086,6 +2086,32 @@ number.") >> @code{org-mode} to be rendered as UTF-8 characters.") >> (license license:gpl3+))) >> >> +(define-public emacs-org-trello >> + (package >> + (name "emacs-org-trello") >> + (version "0.7.9") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://github.com/org-trello/org-trello/archive/" >> + version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf")))) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + `(("emacs-deferred" ,emacs-deferred) >> + ("emacs-request" ,emacs-request) >> + ("emacs-dash" ,emacs-dash) >> + ("emacs-s" ,emacs-s))) >> + (home-page "https://org-trello.github.io") >> + (synopsis "Emacs minor mode for interacting with Trello") >> + (description "This package provides an emacs minor mode to extend > > Please capitalize “Emacs”. Whoops. Fixed in the new patch. > >> +@code{org-mode} with Trello abilities. Trello is an online project >> +organizer.") >> + (license license:gpl3+))) >> + >> (define-public emacs-zenburn-theme >> (package >> (name "emacs-zenburn-theme") > > Other than that it looks good! > > Thanks! There are three failing tests, because it cannot find the test function definitions of itself, or it cannot find the built-in functions: hash-table-keys, hash-table-values, and string-at-pt. I think the tests are malfunctioning, not the functionality, because I can synchronize my Trello boards and lists just fine. Here's the updated patch: >From de2e2f3a5b293d75b5e65fc3081a2ead75149e4c Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Thu, 27 Oct 2016 10:28:51 +0200 Subject: [PATCH] gnu: Add emacs-org-trello. * gnu/packages/emacs.scm (emacs-org-trello): New variable. --- gnu/packages/emacs.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 2a275d0..6af1325 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -2086,6 +2086,35 @@ number.") @code{org-mode} to be rendered as UTF-8 characters.") (license license:gpl3+))) +(define-public emacs-org-trello + (package + (name "emacs-org-trello") + (version "0.7.9") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/org-trello/org-trello/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-deferred" ,emacs-deferred) + ("emacs-request" ,emacs-request) + ("emacs-dash" ,emacs-dash) + ("emacs-s" ,emacs-s) + ("emacs-undercover" ,emacs-undercover) + ("emacs-el-mock" ,emacs-el-mock) + ("emacs-helm" ,emacs-helm))) + (home-page "https://org-trello.github.io") + (synopsis "Emacs minor mode for interacting with Trello") + (description "This package provides an Emacs minor mode to extend +@code{org-mode} with Trello abilities. Trello is an online project +organizer.") + (license license:gpl3+))) + (define-public emacs-zenburn-theme (package (name "emacs-zenburn-theme") -- 2.10.0 Kind regards, Roel Janssen