From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: libreoffice: Add 'libreoffice' symlink. Date: Thu, 08 Dec 2016 23:48:41 +0100 Message-ID: <877f7ahwae.fsf@gnu.org> References: <20161206195241.23575-1-ng0@libertad.pw> <20161206200444.24200-1-ng0@libertad.pw> <20161206200444.24200-2-ng0@libertad.pw> <87wpfcssn8.fsf@gmail.com> <8760mw6b8j.fsf@we.make.ritual.n0.is> <871sxidamm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF7Ud-0008TF-CJ for guix-devel@gnu.org; Thu, 08 Dec 2016 17:48:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF7Ua-0000ia-Bj for guix-devel@gnu.org; Thu, 08 Dec 2016 17:48:47 -0500 In-Reply-To: <871sxidamm.fsf@gmail.com> (Alex Kost's message of "Thu, 08 Dec 2016 12:37:53 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > ng0 (2016-12-06 20:42 +0000) wrote: > >> Alex Kost writes: > [...] >>> I've just noticed that there is 'bin-install' phase right before it, so >>> I think an additional phase is not needed at all, the required >>> symlinking can be done in that 'bin-install' phase. >> >> Okay, I did not want to touch that because I did think for some >> reason it should be separated, but what you provided as diff >> further below looks better than my approach. I'd be okay with >> this. My change is so small, you could probably create your own >> patch and send it to this thread. > > Since it's trivial, I committed it=C2=B9... but then I realized that > originally it was more like a question about adding 'libreoffice' link > along with the 'soffice' one. So I hope other people will not object > that there is 'bin/libreoffice' now :-) Sounds good to me, thanks! :-) Ludo=E2=80=99.