Re: [PATCH 1/2] gnu: Add openvswitch.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3280 bytes --]

宋文武 <iyzsong@member.fsf.org> writes:

> * gnu/packages/networking.scm (openvswitch): New variable.

Cool, thanks a lot for this! I will be using this for sure.

> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 87ee0a1d8..c6fb2cfda 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -1060,3 +1060,57 @@ suddenly a lot of network traffic, you can fire up NetHogs and immediately see
>  which PID is causing this.  This makes it easy to identify programs that have
>  gone wild and are suddenly taking up your bandwidth.")
>      (license license:gpl2+)))
> +
> +(define-public openvswitch
> +  (package
> +    (name "openvswitch")
> +    (version "2.6.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://openvswitch.org/releases/openvswitch-"
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "036gq741j9kqsjlp693nff838c9wjd1c56nswl9vyyd1lsmj0yrh"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(;; FIXME: many tests fail with:
> +       ;;    […]
> +       ;;    test -e $OVS_RUNDIR/ovs-vswitchd.pid
> +       ;;    ovs-appctl -t ovs-vswitchd exit
> +       ;;    hard failure
> +       #:tests? #f

Ah, this brings me back to
https://github.com/NixOS/nixpkgs/commit/4561a649f41554f9c47c0405079a909a1b51db2f

I managed to get everything but bash completion tests working back then,
but did not have the same luck now after about ten minutes of trying. I
will give it a go at a later opportunity unless someone beats me to it ;)

> +       #:configure-flags
> +       '("--enable-shared"
> +         "--localstatedir=/var"
> +         "--with-dbdir=/var/lib/openvswitch")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'install
> +           (lambda _
> +             (zero? (system* "make"
> +                             "RUNDIR=/tmp"
> +                             "PKIDIR=/tmp"
> +                             "LOGDIR=/tmp"
> +                             "DBDIR=/tmp"
> +                             "install")))))))
> +    (native-inputs
> +     `(("perl" ,perl)
> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-2)
> +       ;; for testing
> +       ("util-linux" ,util-linux)))
> +    (propagated-inputs
> +     `(("python-six" ,python2-six)))
> +    (inputs
> +     `(("libcap-ng" ,libcap-ng)
> +       ("openssl" ,openssl)))
> +    (synopsis "Virtual network switch")
> +    (home-page "http://www.openvswitch.org/")
> +    (description
> +     "Open vSwitch is a multilayer virtual switch.  It is designed to enable
> +massive network automation through programmatic extension, while still
> +supporting standard management interfaces and protocols (e.g. NetFlow, sFlow,
> +IPFIX, RSPAN, CLI, LACP, 802.1ag).")
> +    (license license:asl2.0)))

The source ships a handy "debian/copyright" file outlining the various
licenses in use. They should be mentioned here. Could not find any
third-party bundled software at a glance. Otherwise LGTM!

Haven't tested the service, but the definition LGTM too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]