all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
Cc: 26265@debbugs.gnu.org, Alex Sassmannshausen <alex@pompo.co>
Subject: bug#26265: [PATCH 1/1] packages: Add optional `for-ui` param to `package-full-name`.
Date: Tue, 28 Mar 2017 17:06:51 +0200	[thread overview]
Message-ID: <877f3930fo.fsf@gnu.org> (raw)
In-Reply-To: <20170326122555.22366-2-alex@pompo.co> (Alex Sassmannshausen's message of "Sun, 26 Mar 2017 14:25:55 +0200")

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * guix/packages.scm (package-full-name): Add optional parameter `for-ui`.
> * guix/scripts/refresh.scm (list-dependents): Use it.
> * tests/packages.scm: Add tests for `package-full-name`.

[...]

> +(define* (package-full-name package #:optional for-ui)
> +  "Return the full name of PACKAGE--i.e., `NAME-VERSION'.  If FOR-UI? is #t,
> +return the full name of PACKAGE using \"@\" as the NAME, VERSION separator."

I’d replace ‘for-ui’ with:

  #:optional (separator "@")

I think it’s less ambiguous.

That also means that we’d need to change *non*-UI call sites, instead of
changing UI call sites.  Hopefully there are few of them, but as
discussed in the other message, it takes manual analysis to determine
which use requires a hyphen and which one does not.

Thanks,
Ludo’.

      parent reply	other threads:[~2017-03-28 15:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170326122555.22366-1-alex@pompo.co>
     [not found] ` <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr>
     [not found]   ` <877f3bx4m3.fsf@gmail.com>
2017-03-28 15:03     ` bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Ludovic Courtès
2017-03-28 15:19       ` Tobias Geerinckx-Rice
     [not found]         ` <fe8b8924-3c64-e478-4745-24a692db3a91@tobias.gr>
     [not found]           ` <87o9wl1j3k.fsf@gnu.org>
2017-03-28 19:49             ` Tobias Geerinckx-Rice
2017-05-06 18:32         ` Tobias Geerinckx-Rice
2017-05-07 15:37           ` Ludovic Courtès
2017-05-07 21:13             ` Tobias Geerinckx-Rice
2017-05-08 12:39               ` Ludovic Courtès
2017-05-20  9:28           ` Alex Sassmannshausen
2017-05-31 12:11             ` Ludovic Courtès
     [not found] ` <20170326122555.22366-2-alex@pompo.co>
2017-03-28 15:06   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f3930fo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26265@debbugs.gnu.org \
    --cc=alex.sassmannshausen@gmail.com \
    --cc=alex@pompo.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.