From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu6Pj-0001Jq-Ce for guix-patches@gnu.org; Fri, 31 Mar 2017 19:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu6Pf-0002NH-3U for guix-patches@gnu.org; Fri, 31 Mar 2017 19:57:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cu6Pe-0002NA-TT for guix-patches@gnu.org; Fri, 31 Mar 2017 19:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cu6Pe-0001FS-Go for guix-patches@gnu.org; Fri, 31 Mar 2017 19:57:02 -0400 Subject: bug#26316: Enable threaded compression of source tarballs Resent-Message-ID: From: Kei Kebreau References: <20170330221715.GA10357@jasmine> <87efxd5n3r.fsf@openmailbox.org> <20170331230413.GB9642@jasmine> Date: Fri, 31 Mar 2017 19:56:18 -0400 In-Reply-To: <20170331230413.GB9642@jasmine> (Leo Famulari's message of "Fri, 31 Mar 2017 19:04:13 -0400") Message-ID: <877f3557bx.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 26316@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Fri, Mar 31, 2017 at 02:15:36PM -0400, Kei Kebreau wrote: >> Leo Famulari writes: >> > Subject: [PATCH] packages: Enable threaded compression of source tarba= lls. > >> > - "cvfa" #$output >> > + "cvf" #$output >> > + ;; The bootstrap xz does not su= pport >> > + ;; threaded compression (introduced in >> > + ;; 5.2.0), but it ignores the extra flag. >> > + (string-append "--use-compress-program=3D" >> > + #+xz "/bin/xz --threads=3D0") > > One question I have is about the removal of 'cvfa'. Here is the relevant > documentation: > > -a, --auto-compress > Use archive suffix to determine the compression > program. > > AFAICT, we only build XZ archives, so it's okay to remove 'a' and > hard-code the use of xz. Is that correct? > The surrounding code definitely seems to suggest that. Reading "up" the code from the gexp->derivation call I can find hardcoded xz usage in the tarxz-name procedure and this bit: (mlet %store-monad ((tar -> (lookup-input "tar")) ->(xz -> (lookup-input "xz")) (only xz here!)/ (patch -> (lookup-input "patch")) (locales -> (lookup-input "locales")) (decomp -> (lookup-input decompression-type)) (patches (sequence %store-monad (map instantiate-patch patches)))) >> > ;; avoid non-determinism in >> > the archive >> > "--mtime=3D@0" >> > "--owner=3Droot:0" >>=20 >> LGTM. > > Thanks! This does mean rebuilding the world, so we'd need to save it for > the next core-updates cycle. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlje7KMACgkQ5qXuPBlG eg0yJxAAlBLapj0RbRrFF3zNg/peTHD1mowdQp8y538EBhOut121+Ud6tEu0Ygx/ 2T3PxW4xfLXAIGvl55IbINsyjYSbkM7SdM2J/i2DqXKFFmLMoVI67tMhOjA3PIVz eW0z/An/gwqRwHWN77/I1hwMhFmCvb29qV43erMpuL8xfWAw+zUns6n+TxzJtqyu +VASNwRMjVxg5q4AUYJwWpNH4XXteAGD88+mUN7c7P+DRrJiJrFRsACqlzMXS8Rs +PiGyU3uNZkz8hJLGo5ap7wd6ddedKw/hwMzVUWJFkUQK4GXCu5qU0s00uKd1lKO 4buot7MKYkGcHGP+jaKU0IB6CNcmmEN110sSjHl5abIKKTSIZHgoFi3Xpyo2WCrf WmE+YUUd34y2dxA1u+EPxWWrLeKAd+WvmjumHdyf9eBIPoGneebbrXJZB+OFP2BM e+kNMoVIASn+/O91NO1cO2KBLUcRxsc7mIMgeGEysxq9qIYIGSFIUpR2D8RYWqrZ nhku5eXGt0qOZ0OQxfonNm2UHwM0OQP/sOASos80v8MNt2pFtarAZoHGBE3WGaCI XLt794nfkz7wSZfu0w5fV09jewFam57+789P4x6XJ7pfsI4XFtCSC9A0PpEZ4fKs vhLio3Wp1te62oGMo3dxgw5qFPSmhfqY3un2CjWffT7MHf5w2wg= =RsTh -----END PGP SIGNATURE----- --=-=-=--