From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1ARU-0003Kd-AW for guix-patches@gnu.org; Thu, 20 Apr 2017 07:40:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1ARO-0002qr-Dd for guix-patches@gnu.org; Thu, 20 Apr 2017 07:40:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59835) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d1ARO-0002qi-9M for guix-patches@gnu.org; Thu, 20 Apr 2017 07:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d1ARN-0001ey-Vp for guix-patches@gnu.org; Thu, 20 Apr 2017 07:40:02 -0400 Subject: bug#26559: [PATCH] build: emacs: Install only a subset of files. Resent-Message-ID: From: Alex Kost References: <20170419073525.2357-1-arunisaac@systemreboot.net> Date: Thu, 20 Apr 2017 14:39:24 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 19 Apr 2017 13:25:12 +0530") Message-ID: <877f2fqpeb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 26559@debbugs.gnu.org Arun Isaac (2017-04-19 13:25 +0530) wrote: > This is a work in progress patch for the discussion at > https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00274.html > > All feedback welcome! Great, thanks for working on it! > Arun Isaac writes: > >> + (include ''(".*.el$" ".*.el.in$" "^dir$" >> + ".*.info$" ".*.texi$" ".*.texinfo$" >> + "doc/dir" "doc/*.info$" "doc/*.texi$" "doc/*.texinfo$")) >> + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests.el$" ".*-test.el$" ".*-tests.el$")) > > I've copied all this from MELPA's default :files property described at > https://github.com/melpa/melpa . I have no idea what the rationale for > some of these regexes are. What regexps are not clear for you? > Currently, include and exclude are a list of regexes that file names are > matched against. Should this be combined into one big regex? I think it is not needed, it is more clean to separate regexps. > Would it be a good idea to add a third keyword argument, say > #:documentation, that will select info documentation files and install > them separately in some other directory? Regarding documentation: note that it is already installed into the proper place. I mean if the package has ".info" files, they are installed into "share/info" (look at 'move-doc' procedure in (guix build emacs-build-system) module). For example, 'emacs-debbugs' has the info manual and it is installed appropriately. So I think #:documentation is not needed. Also I would like to note that this patch (when it will be ready) shouldn't be committed alone: there are some emacs packages that should be adjusted to include additional files. One that comes to mind is 'emacs-slime' - it *must* contain *.lisp files (and other files as listed at ). Otherwise, it wouldn't work at all. So I think this patch should be committed with the according fixes for such "complex" packages (not sure if there are other ones along with 'emacs-slime'). -- Alex