From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d488o-0007r9-0t
	for guix-patches@gnu.org; Fri, 28 Apr 2017 11:49:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d488k-0008Uz-Ud
	for guix-patches@gnu.org; Fri, 28 Apr 2017 11:49:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46697)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d488k-0008Ut-Qx
	for guix-patches@gnu.org; Fri, 28 Apr 2017 11:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d488k-0002Xg-F1
	for guix-patches@gnu.org; Fri, 28 Apr 2017 11:49:02 -0400
Subject: bug#26676: [PATCH] gnu: Add xerces-c.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.26676.D26676.14933945039702.done@debbugs.gnu.org>
References: <20170427065236.20963-1-rekado@elephly.net>
	<87h91ac730.fsf@fastmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87h91ac730.fsf@fastmail.com>
Date: Fri, 28 Apr 2017 17:48:15 +0200
Message-ID: <877f24y1mo.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26676-done@debbugs.gnu.org


Marius Bakke <mbakke@fastmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/xml.scm (xerces-c): New variable.
>
> [...]
>
>> +(define-public xerces-c
>> +  (package
>> +    (name "xerces-c")
>> +    (version "3.1.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://apache/xerces/c/3/sources/"
>> +                                  "xerces-c-" version ".tar.xz"))
>> +              (sha256
>> +               (base32
>> +                "0hb29c0smqlpxj0zdm09s983z5jx37szlliccnvgh0qq91wwqwwr"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:configure-flags (list "--disable-sse2")))
>
> SSE2 is part of the AMD64 specification[0], so enabling it for x86_64
> would be slightly nicer. Other than that looks good!
>
> [0] https://en.wikipedia.org/wiki/SSE2#CPU_support

Ah, you’re right.  I pushed it with a fix with commit 162a4a032^.
Thanks for the review!

--
Ricardo

  GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
  https://elephly.net