From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 04/04: offload: Avoid using '_' as a 'match' pattern.
Date: Wed, 03 May 2017 16:18:12 +0200
Message-ID: <877f1yrpln.fsf@gnu.org>
References: <20170421152428.28671.46379@vcs0.savannah.gnu.org>
	<20170421152430.15A4A21037@vcs0.savannah.gnu.org>
	<f85f2324-b672-905c-96b1-a97798220212@tobias.gr>
	<87pog5brmt.fsf@gnu.org> <87efwlzlf7.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1d5v6g-0002A6-JE
	for guix-devel@gnu.org; Wed, 03 May 2017 10:18:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1d5v6d-0002QH-CC
	for guix-devel@gnu.org; Wed, 03 May 2017 10:18:18 -0400
In-Reply-To: <87efwlzlf7.fsf@netris.org> (Mark H. Weaver's message of "Fri, 21
	Apr 2017 14:05:00 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>> In hindsight, it would have been wiser to just rename =E2=80=98_=E2=80=
=99 in (guix ui)
>> to something else, like =E2=80=98G_=E2=80=99.  Well, it=E2=80=99s not to=
o late.  Should we do
>> that?  Thoughts?
>
> I agree that renaming '_' in (guix ui) is the better approach.

Done in 69daee23af49aeafcb1d250c90860f9253da719e.

The downside is that I had to disable -Wformat, which reported too many
=E2=80=9Cnon-literal format string=E2=80=9D: -Wformat assumes that the =E2=
=80=98gettext=E2=80=99
procedure can be called =E2=80=98_=E2=80=99, and otherwise emits that warni=
ng.

We should do something on the Guile side to fix this, perhaps by
allowing users to annotate identifiers as being gettext-like procedures.

Thoughts?

Ludo=E2=80=99.