From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Wr3-0001f3-DQ for guix-patches@gnu.org; Sat, 13 May 2017 09:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9Wr0-00019T-Nk for guix-patches@gnu.org; Sat, 13 May 2017 09:13:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39212) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9Wr0-00019E-Jm for guix-patches@gnu.org; Sat, 13 May 2017 09:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9Wr0-00068p-E9 for guix-patches@gnu.org; Sat, 13 May 2017 09:13:02 -0400 Subject: bug#26772: [PATCH 2/3] import: cran: Robustify cran-package?. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170504100627.27553-1-m.othacehe@gmail.com> <20170504100627.27553-2-m.othacehe@gmail.com> <87bmqx6807.fsf@gnu.org> <87fug9828m.fsf@gmail.com> Date: Sat, 13 May 2017 15:12:38 +0200 In-Reply-To: <87fug9828m.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 13 May 2017 12:44:57 +0200") Message-ID: <877f1k529l.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26772-done@debbugs.gnu.org Mathieu Othacehe skribis: >> Do you think you could add this specific case (r-minimal) as a test case >> for =E2=80=98cran-package?=E2=80=99 in tests/cran.scm? That would be aw= esome. >> >> Otherwise LGTM, thanks! > > Sure I pushed this patch with the change above and a new test in > tests/cran.scm : > > (test-equal "r-mininal is not a cran package" > #f > ((@@ (guix import cran) cran-package?) r-minimal)) > > I also pushed the two other patches of the serie. Perfect, thank you! Ludo=E2=80=99.