From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dH9TL-0008JW-64
	for guix-patches@gnu.org; Sat, 03 Jun 2017 09:52:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dH9TI-0005t4-3h
	for guix-patches@gnu.org; Sat, 03 Jun 2017 09:52:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49806)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dH9TI-0005se-0r
	for guix-patches@gnu.org; Sat, 03 Jun 2017 09:52:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dH9TH-0005wf-RP
	for guix-patches@gnu.org; Sat, 03 Jun 2017 09:52:03 -0400
Subject: bug#27049: [PATCH 1/2] gnu: Add font-mathjax.
Resent-Message-ID: <handler.27049.B27049.149649791722832@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <15cc163d.ADsAAWz_hBsAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZJK0O@mailjet.com>
	<e8f89499.AEQALGA6JBUAAAAAAAAAAAPEb_oAAAACwQwAAAAAAAW9WABZMcuY@mailjet.com>
Date: Sat, 03 Jun 2017 15:51:44 +0200
In-Reply-To: <e8f89499.AEQALGA6JBUAAAAAAAAAAAPEb_oAAAACwQwAAAAAAAW9WABZMcuY@mailjet.com>
	(Arun Isaac's message of "Sat, 3 Jun 2017 02:03:07 +0530")
Message-ID: <877f0tmb67.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 27049@debbugs.gnu.org

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/fonts.scm (font-mathjax): New variable.

[...]

> +(define-public font-mathjax
> +  (package
> +    (name "font-mathjax")
> +    (version "2.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/mathjax/MathJax/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0sbib5lk0jrvbq6s72ag6ss3wjlz5wnk07ddxij1kp96yg3c1d1b"))))

Should it be:

  (source (package-source mathjax))

to make sure the two packages are kept in sync?

> +    (home-page "https://www.mathjax.org/")
> +    (synopsis "JavaScript display engine for LaTeX, MathML, and AsciiMat=
h")
> +    (description "MathJax is a JavaScript display engine for LaTeX, Math=
ML,
> +and AsciiMath notation that works in all modern browsers.  It requires no
> +plugins or software to be installed on the browser.  So the page author =
can
> +write web documents that include mathematics and be confident that reade=
rs will
> +be able to view it naturally and easily.")
> +    (license license:asl2.0)))

I think the synopsis/description should be updated to mention that this
package simply provides the font used by MathJax, no?

Otherwise LGTM, thanks!

Ludo=E2=80=99.