From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44185)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRghJ-0008Cm-BO
	for guix-patches@gnu.org; Sun, 02 Jul 2017 11:22:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRghG-0004Zu-7J
	for guix-patches@gnu.org; Sun, 02 Jul 2017 11:22:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46244)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dRghG-0004Zb-3N
	for guix-patches@gnu.org; Sun, 02 Jul 2017 11:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dRghF-0005X4-Tn
	for guix-patches@gnu.org; Sun, 02 Jul 2017 11:22:01 -0400
Subject: [bug#27554] Add dirvish and dependencies
Resent-Message-ID: <handler.27554.B27554.149900886421199@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <8737afvbwd.fsf@dustycloud.org>
Date: Sun, 02 Jul 2017 17:20:37 +0200
In-Reply-To: <8737afvbwd.fsf@dustycloud.org> (Christopher Allan Webber's
	message of "Sat, 01 Jul 2017 20:57:22 -0500")
Message-ID: <877ezq7tmi.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: 27554@debbugs.gnu.org

Hi Chris!

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> From 60a448f1daf37927155577dabaf1c090f9404bee Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Sat, 1 Jul 2017 20:45:04 -0500
> Subject: [PATCH 1/3] gnu: Add perl-libtime-parsedate.
>
> * gnu/packages/perl.scm (perl-libtime-parsedate): New variable.

[...]

> +    (arguments
> +     ;; Output when running tests:
> +     ;;   t/metdate.t ... skipped: It seems localtime() does not honor
> +     ;;   $ENV{TZ} when set in the test script.
> +     ;; Seemingly related:
> +     ;;   https://stackoverflow.com/questions/19956693/timeparsedate-ins=
tall-fail
> +     ;;   https://rt.cpan.org/Public/Bug/Display.html?id=3D90367
> +     `(#:tests? #f))

Perhaps if we add a dependency on tzdata and set TZDIR, as is done for
=E2=80=98duplicity=E2=80=99 for instance, the tests would run?

Anyway this probably shouldn=E2=80=99t block the whole series!

> From f475a133812a4d62e32a90caa26f41bb242f8a37 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Sat, 1 Jul 2017 20:46:00 -0500
> Subject: [PATCH 2/3] gnu: Add perl-libtime-period.
>
> * gnu/packages/perl.scm (perl-libtime-period): New variable.

[...]

> +    (license (package-license perl))))

Please use =E2=80=98license:perl-license=E2=80=99 here.

> From 01b0c93222658f74d5049f1666d383efacf4a724 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Sun, 20 Nov 2016 10:36:46 -0600
> Subject: [PATCH 3/3] gnu: Add dirvish.
>
> * gnu/packages/backup.scm (dirvish): New variable.

[...]

> +    (home-page "http://dirvish.org/")
> +    (license (license:fsf-free "file://COPYING")))) ; Open Software Lice=
nse 2.0

You can make it:

   (license:fsf-free "file://COPYING"
                     "Open Software License 2.0")

OK with these changes, thank you!

Ludo=E2=80=99.