From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYBJE-0003WC-RA for guix-patches@gnu.org; Thu, 20 Jul 2017 09:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYBJC-0007ex-4p for guix-patches@gnu.org; Thu, 20 Jul 2017 09:16:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYBJC-0007ed-23 for guix-patches@gnu.org; Thu, 20 Jul 2017 09:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYBJB-0003Ei-M4 for guix-patches@gnu.org; Thu, 20 Jul 2017 09:16:01 -0400 Subject: [bug#27767] [PATCH] gnu: Add eolie. Resent-Message-ID: References: <20170719215609.15359-1-rekado@elephly.net> <87r2xbxw77.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: <87r2xbxw77.fsf@gnu.org> Date: Thu, 20 Jul 2017 15:15:27 +0200 Message-ID: <877ez3fdw0.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Roel Janssen Cc: 27767@debbugs.gnu.org Hi Roel, > I guess I'm too late, but here are some comments. Thanks for taking the time to comment. >> + (add-after 'wrap 'wrap-more >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + ;; These libraries must be on LD_LIBRARY_PATH. >> + (libs '("gtkspell3" "webkitgtk" "libsoup" "libsecret" >> + "atk" "gtk+" "gsettings-desktop-schemas" >> + "gobject-introspection")) >> + (path (string-join >> + (map (lambda (lib) >> + (string-append (assoc-ref inputs lib) "/lib")) >> + libs) >> + ":"))) >> + (wrap-program (string-append out "/bin/eolie") >> + `("LD_LIBRARY_PATH" ":" prefix (,path)) > > This makes it work, but is this something we want to do here? > There seems to be a deeper issue with how libraries are found. I realise that this is not pretty, but I haven’t been able to find a better way to fix this. IIUC the libraries are not loaded by eolie directly, but through the gobject introspection mechanism. It seems to me that we need to find a way to fix that mechanism instead of trying to change client applications. > I tested the browser and it seems to work quite well, except for: > - Ads are not blocked, even when the "Block ads" checkbox is checked. It seems to me that *some* ads are indeed blocked, but by far not all of them. This seems to be due to a very rudimentary adblock list. > - It seems to be cloning a repository for adblock_js when running the program: > > roel@antelope ~/sources/guix$ /gnu/store/ccvdhd5159qkachbzf4y9k5c6ds4cn4n-eolie-0.9.0/bin/eolie > Cloning into '/home/roel/.local/share/eolie/adblock_js'... > Could not initialize PyGObjectremote: Counting objects: 74, done. > remote: Total 74 (delta 0), reused 0 (delta 0), pack-reused 74 > Unpacking objects: 100% (74/74), done. > > The 'remote' for this repository is: > https://github.com/gnumdk/eolie-adblock.git This is the block list. Epiphany does something similar regularly, though it will just fetch a single file and not use git. I wonder if eolie will fall back to using some other mechanism to get an up-to-date block list when git is not available. > - I get a couple of Gtk-WARNINGs: […] > - And a couple of more warnings: […] I get some of these too, but they don’t seem to affect the browser features much. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net