From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJPNz-0001ui-7H for guix-patches@gnu.org; Mon, 27 Nov 2017 14:48:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJPNr-0001ws-AG for guix-patches@gnu.org; Mon, 27 Nov 2017 14:48:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJPNr-0001we-6q for guix-patches@gnu.org; Mon, 27 Nov 2017 14:48:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJPNq-0005HY-P0 for guix-patches@gnu.org; Mon, 27 Nov 2017 14:48:02 -0500 Subject: bug#29468: [PATCH 2/2] gnu: Patch udisks to directly reference cryptsetup and parted. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87k1ycf74y.fsf@cbaines.net> <20171127084815.20587-1-mail@cbaines.net> <20171127084815.20587-2-mail@cbaines.net> <87r2sjlsno.fsf@gnu.org> From: Christopher Baines In-reply-to: <87r2sjlsno.fsf@gnu.org> Date: Mon, 27 Nov 2017 19:47:31 +0000 Message-ID: <877eubijvw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29468-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> This fixes some functionality in gnome-disks, which uses udisks. Adding >> cryptsetup enables creating partitions using LUKS, and adding parted ena= bles >> editing the partition tables through the disks application. >> >> * gnu/packages/freedesktop.scm (udisks)[inputs]: Add cryptsetup and part= ed. >> (arguments): Rename set-mount-file-name phase, and add cryptsetup and >> parted. > > I think the explanation above should be a comment, but otherwise LGTM. > > Thanks for fixing it! No problem, I've added a couple of comments and pushed. Thanks for reviewing :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAloca9NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfiog/6AmFWoENsRurB5cn4D271HMvwf+pe2+3ehhZPHkJxtJ3O+NOsX2xxkMJp QmVqtOAu31hvpDgW8ZT9R4iVjCVCIBB0HOf3RCqXCroL++qzTrXQgMGv3ni7bPl8 h8OZml8OZ1AwPSvFl43uOQzMAI0Kke/vPxpd6JG7KebmjQO3OZK3TwFpaefZAvyE cKEHkjQ6uLdDp3BG1WJ2rFWEyWT5A/OYrSMUHTc1NeFHespqCcSXhK2wivkJThm3 SqfVC3l2T++Hai8ldgQJTi8Lc6FNJtQzcToYIwYZNfEcr5kJDKp645MQ71JECzR1 IgxMuT7PSkVg+04Oy6QH4T83C/Wbw6jgaLg6pRO1ngZCuA+yxzuAroTnLFImksGm mlD65xJ6pN6RLJbhG/tlDb42LO9tQB+k32FfdHvKe9oLv0N9hoJoWSqzNNsku1te i+CuFm199Rtk52cev3WZkhBN6oFDJiqNUTooEp527Up5vpYe48Lq7CPRrcn8tAdX iaFw0EoNcV9ubsHHJYRKc7a5hqqKHvz479il1M/Qy8mmsj2wmbwwcQkWa0H5QLa8 DfF7r25vwCJNzTVtAwRJeHsABWiqCOfu0mGfpwvm69WYO2TlOUd7VPA4Ik7j0IrU rcX1ekKQ2d15/wW92bmuL4hXbRIUI7Xfz7jbqFBSW/6CgmOqUp8= =FS4K -----END PGP SIGNATURE----- --=-=-=--