From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb4tq-0002Vf-7j for guix-patches@gnu.org; Mon, 15 Jan 2018 08:34:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb4tm-0005a0-6x for guix-patches@gnu.org; Mon, 15 Jan 2018 08:34:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eb4tm-0005Zn-36 for guix-patches@gnu.org; Mon, 15 Jan 2018 08:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eb4tl-0004sZ-N2 for guix-patches@gnu.org; Mon, 15 Jan 2018 08:34:01 -0500 Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87po6gm5l6.fsf@gnu.org> <87tvvntjpe.fsf@gmail.com> Date: Mon, 15 Jan 2018 14:33:22 +0100 In-Reply-To: <87tvvntjpe.fsf@gmail.com> (Oleg Pykhalov's message of "Mon, 15 Jan 2018 15:01:01 +0300") Message-ID: <877esjgsbh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, 28832-done@debbugs.gnu.org, Alex Kost Hi Oleg, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > > [...] > >>>> From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 >>>> From: Oleg Pykhalov >>>> Date: Tue, 12 Dec 2017 01:41:08 +0300 >>>> Subject: [PATCH] gnu: Add emacs-json-reformat. >>>> >>>> * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. >>>> * gnu/local.mk (dist_patch_DATA): Add this. >>>> * gnu/packages/emacs.scm (emacs-json-reformat): New variable. >>> >>> [...] >>> >>>> diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch = b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>>> new file mode 100644 >>>> index 000000000..23a239582 >>>> --- /dev/null >>>> +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch >>>> @@ -0,0 +1,28 @@ >>>> +Copyright =C2=A9 2017 Oleg Pykhalov >>>> + >>>> +This patch fixes tests for Emacs 25. >>> >>> Please mention here. >>> >>> OK with these changes! >> >> We went on discussing other things and forgot about the patch. :-) >> Could you commit it with these changes, Oleg? > > I thought we suspend this until automation of "-L" flags. No no, the =E2=80=9COK with these changes=E2=80=9D above really means you c= an go ahead. :-) The =E2=80=9C-L=E2=80=9D discussion is about an improvement we should make,= but it should not block this patch. > Seems like a similar discussion[1] gets stuck too. > Pushed as b0912e9fdbffab15d9a754b2922778cfbd1fac2a Yeah, though I don=E2=80=99t think you should wait for Alex or anyone else = to make a decision: if you have an idea on how to improve this, based on these discussions, then you=E2=80=99re probably in a good position to do it= and everyone will be happy. ;-) > Also pushed emacs-json-mode as dd72837dff128dbb1258826fe39467d1ef000ac1 Great, thank you! Ludo=E2=80=99.