From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er4H0-0006Us-As for guix-patches@gnu.org; Wed, 28 Feb 2018 11:08:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er4Gw-0003mn-AX for guix-patches@gnu.org; Wed, 28 Feb 2018 11:08:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1er4Gw-0003m7-26 for guix-patches@gnu.org; Wed, 28 Feb 2018 11:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1er4Gv-0001qZ-Pc for guix-patches@gnu.org; Wed, 28 Feb 2018 11:08:01 -0500 Subject: bug#30598: [PATCH 0/5] gnu: Add youtube-viewer. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <87efl74khh.fsf@gmail.com> References: <87sh9qvuhz.fsf@gmail.com> <87k1v0woiv.fsf@fastmail.com> <87efl74khh.fsf@gmail.com> Date: Wed, 28 Feb 2018 17:07:44 +0100 Message-ID: <877eqxumgf.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Vong Cc: 30598-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Alex Vong writes: > Marius Bakke writes: > >> Alex Vong writes: >> >>> Tags: patch >>> >>> Hello, >>> >>> This patch series adds youtube-viewer and its dependencies. It can be >>> used for searching youtube videos without running javascript. It also >>> plays nice with tor which is a plus. >> >> Thanks for this series! The patches LGTM, but can you move the perl >> packages to gtk.scm and glib.scm respectively? That seems more >> appropriate, as we already have e.g. pygtk in gtk.scm, and also avoids >> some top-module cross-references. >> >> (Additionally, perl.scm is huge, so it's good to spread the load to >> appease the Guile compiler) >> >> Thanks in advance! :-) > > (I messed up my mail settings, so I am re-sending.) > > The next patch series should fix everything you've mentioned so far. I > don't understand why wrap-program is used before but now I do. Excellent, thank you! I moved the perl-cairo and perl-pango packages to gtk.scm as well and pushed the series as b0a2c9cbe..6f45e45d4. > Thanks for your review also! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqW09AACgkQoqBt8qM6 VPoH+wf/fk7NCFMluzqdm4W21PMog4hzwva8z4kB/JgWe34R1ru9dk2HmwGp+6qm ry2Qe4VETIeMbZhsTKXJKc9girND9yx/d2E5LuilP94RAy6wBSE4DCjSIlxXEUk1 9vo3LBY/WtZ+j728Uc7A6MDpFPdVVB2rBKWtBRiJmXIPJDyj588YgGg45hixTOIA QD/xtGlBtcq8t2ow8CcubFAUp3ndhcsdwyaGRWPesqXFvE9T1m6p3iqXwDVDvkpu 04Cnqta/9qeD69gJsqLOTYazzWGfAfCnkyYO+eLuzJjoWhZfRAPit3R3PKy39AXG PfqTiLblT/qf7VzNn+9uB7fE0T21UA== =HPzr -----END PGP SIGNATURE----- --=-=-=--