From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5dll-0007Gz-9u for guix-patches@gnu.org; Mon, 09 Apr 2018 16:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5dli-0008Jl-88 for guix-patches@gnu.org; Mon, 09 Apr 2018 16:52:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36411) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f5dli-0008Jg-3U for guix-patches@gnu.org; Mon, 09 Apr 2018 16:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f5dlh-0000QM-Mu for guix-patches@gnu.org; Mon, 09 Apr 2018 16:52:01 -0400 Subject: [bug#31114] [PATCH] gnu: Add fortune-mod. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180409173217.7629-1-ambrevar@gmail.com> <878t9w9t57.fsf@gmail.com> Date: Mon, 09 Apr 2018 22:51:54 +0200 In-Reply-To: <878t9w9t57.fsf@gmail.com> (Pierre Neidhardt's message of "Mon, 09 Apr 2018 23:09:00 +0530") Message-ID: <877epggl1x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31114@debbugs.gnu.org Hi, Pierre Neidhardt skribis: > A few questions: > > - Tests need perl-run-valgrind or something like that which is not in > the repo yet. I guess it would be better to add it. Should I do it? > I know nothing about Perl packagin, so if something feels like giving > it a shot... =E2=80=98guix import cpan=E2=80=99 feels like giving it a shot. :-) More seriously, if Valgrind testing is optional, it=E2=80=99s OK to leave i= t out IMO. The other tests would be nice to have, and the Perl packages are probably easy to import if you wanted to try, but that shouldn=E2=80=99t be= a blocker IMO. > - A cmake file is deliberately missing from the source (strange > engineering methods...) so I included it as a patch. Not so > convenient. Is it possible to add several sources so that the missing > file gets downloaded from its separate git repository? You can add an =E2=80=98origin=E2=80=99 in =E2=80=98inputs=E2=80=99. It wo= uld be preferable than adding it as a patch, indeed. Would you like to give it a try? Thanks, Ludo=E2=80=99.