From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUBqD-0006l1-Ch for guix-patches@gnu.org; Sat, 16 Jun 2018 10:06:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUBq8-00039W-DX for guix-patches@gnu.org; Sat, 16 Jun 2018 10:06:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUBq8-000394-9F for guix-patches@gnu.org; Sat, 16 Jun 2018 10:06:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUBq6-0002m0-Ah for guix-patches@gnu.org; Sat, 16 Jun 2018 10:06:04 -0400 Subject: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5. Resent-Message-ID: References: <20180606094730.15892-1-ambrevar@gmail.com> <87o9gd2zcy.fsf@posteo.net> <87lgbh2yv5.fsf@posteo.net> From: Pierre Neidhardt In-reply-to: <87lgbh2yv5.fsf@posteo.net> Date: Sat, 16 Jun 2018 16:04:57 +0200 Message-ID: <877emyhlo6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 31733@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >> Any particular reason you decided to use '(zero? (system* ...))' rather >> than '(invoke ...)' for this phase? I tried it with 'invoke' and it >> worked fine. I did not know about `invoke' :) I just found its definition in guix/build/utils.scm. > Also, do note that the snippet needs to be updated, as bundled libraries > (now including googletest) have moved to the "vendor" subdirectory. Once > you remove the "vendor" subdirectory, you may have to add 'googletest' > from '(gnu packages check)' to the native-inputs. So the vender directory has 3 dependencies: =2D tinyxml which is already used externally, so it's safe to remove the embedded version. =2D easyloggingpp which is not packaged in Guix I believe. We need to package it first before we can remove it. =2D googletest: this one does not have an option in CMakeList.txt to be used externally. So either we report upstream or we patch the CMakeList.txt. All things considered, why not sticking to the vendored libraries? What do you think? =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlslGQkACgkQm9z0l6S7 zH9Cfwf/fBH36c0HuXztCSNGdC/IHrTlHDQfzcQ20l06Il6538XEiPQ1/zzj+NUQ 3O73agyGwxuf89SNboX3snra01XVJRRLXmMMcmg/PNmd8Cjp2k5wZLOpuPYIj8ZA shBsVeHCnThfZ067qftKV1fxj8bNIUadWAgxta/74ew4b7BdimEZXmOHllhzrdLH 0FFBETZG/b1G0catlPZlFN13x0xJDc211MBUAi/4R4YWwYPk1fPcQqkBWSP/FI98 IVx9XPVol4p2hsBfUMsZ0U9/QkE4Fw84YOTkIyPScV4KJ3HtY6rLoBTM1pkYwIq3 CdTKQsoFRy0ACfO1hmb1gxjVMsJsOA== =lEn/ -----END PGP SIGNATURE----- --=-=-=--