From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: build-system/meson: Really skip the 'fix-runpath' phase on armhf. Date: Mon, 02 Jul 2018 20:06:08 +0200 Message-ID: <877emdwm0f.fsf@fastmail.com> References: <20180702101757.22792.51026@vcs0.savannah.gnu.org> <20180702101758.97A6020543@vcs0.savannah.gnu.org> <8736x1r1g0.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa3DL-00051t-AF for guix-devel@gnu.org; Mon, 02 Jul 2018 14:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa3DI-0006Vn-4k for guix-devel@gnu.org; Mon, 02 Jul 2018 14:06:15 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54001) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fa3DH-0006Uu-NP for guix-devel@gnu.org; Mon, 02 Jul 2018 14:06:11 -0400 In-Reply-To: <8736x1r1g0.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark H Weaver writes: > Hi Marius, > > mbakke@fastmail.com (Marius Bakke) writes: > >> mbakke pushed a commit to branch staging >> in repository guix. >> >> commit cb4b508cd68df89bfbd5255a0c5569f8318ad50f >> Author: Marius Bakke >> Date: Mon Jul 2 12:07:58 2018 +0200 >> >> build-system/meson: Really skip the 'fix-runpath' phase on armhf. >>=20=20=20=20=20 >> This follows up commit d5b5a15a4046362377f1a45d466b43bb6e93d4f which= doesn't >> work because %current-system etc expands before the actual build. > > I'm disappointed by this workaround that simply removes the > 'fix-runpath' phase on armhf. Is that phase needed, or is it truly > optional? What does the phase accomplish, and how will armhf users be > disadvantaged by the removal of that phase? > > This feels like "sweeping the problem under the rug" to me. It *is* sweeping the problem under the rug, no doubt. The only alternatives I can see is fixing patchelf on armhf, which is difficult for me without access to hardware; fixing Meson itself, which may be easier, but then we may not be able to merge staging in a long time; or implement patchelf functionality in Guix as Ludovic started with and is currently in 'core-updates'. Do you have other suggestions? >> Fixes . > > I don't see the connection between that bug and this commit. > How does this commit fix that bug? Whoops, typo. It should be . --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAls6aZAACgkQoqBt8qM6 VPrLiQgAlBElQZBrnvYAwHR8F/WDX95LHZW14/bMsT5IOqH3nwuMoOsvYNlBnzSe l4HjsdO1XA6syJfEZuNbiAHo4nCUSG6291SS5ujNIql2tw/6aifT40hTbttla0BR rS/QyEnRNh7hzIlVuVv+pf412QqBU8DoXqelQGqV5fd87S67aFlBV0q3h8LGxiYg 98jQoeLka8V5sJKmAdozyoSE8Ev8bcRfRlbtyX3F12rQpLLjpWJPWFhkIAALLYLS 1rUPuhJbKG6EXovx51RJ56oYYeeFly0r2FppB/01nWlliTnfnsOHD3wLo+YOalJr zjMV/3DLOpohJExhyCtOAffVH1+n6w== =i9Gk -----END PGP SIGNATURE----- --=-=-=--