From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faCz1-00065Z-Al for guix-patches@gnu.org; Tue, 03 Jul 2018 00:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faCyy-00087d-66 for guix-patches@gnu.org; Tue, 03 Jul 2018 00:32:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faCyy-00087X-1N for guix-patches@gnu.org; Tue, 03 Jul 2018 00:32:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faCyw-0007xn-9H for guix-patches@gnu.org; Tue, 03 Jul 2018 00:32:03 -0400 Subject: [bug#32031] [PATCH] gnu: Add keynav. Resent-Message-ID: From: Oleg Pykhalov References: <20180702042523.16181-1-go.wigust@gmail.com> <87bmbpej1v.fsf@gnu.org> Date: Tue, 03 Jul 2018 07:31:03 +0300 In-Reply-To: <87bmbpej1v.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 02 Jul 2018 17:47:24 +0200") Message-ID: <877emd3pq0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32031@debbugs.gnu.org, 32031-done@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Thank you for review. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Oleg Pykhalov skribis: > >> * gnu/packages/xorg.scm (keynav): New variable. > > [...] > >> + (arguments >> + `(#:tests? #f > > Could you leave a comment explaining why tests are skipped? If an X > server is needed, we can launch Xvfb before the =E2=80=98check=E2=80=99 p= hase, as many > packages do. Ah, I should did this in the first place, sorry. There are no tests. >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'setenv >> + (lambda _ >> + (setenv "CC" (which "gcc")))) >> + (add-after 'unpack 'patch-keynav >> + (lambda _ >> + (substitute* "keynav.c" >> + (("xdo_symbol_map") "xdo_get_symbol_map") >> + (("xdo_window_setclass") "xdo_set_window_class") >> + (("xdo_window_get_active") "xdo_get_window_at_mouse") >> + (("xdo_click") "xdo_click_window") >> + (("xdo_mouseup") "xdo_mouse_up") >> + (("xdo_mousedown") "xdo_mouse_down") >> + (("xdo_mousemove") "xdo_move_mouse") >> + (("xdo_mousemove_relative") "xdo_move_mouse_relative") >> + (("xdo_mouselocation") "xdo_get_mouse_location") >> + (("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move= _to") >> + (("xdo_keysequence_up") "xdo_send_keysequence_window_up") >> + (("xdo_keysequence_down") "xdo_send_keysequence_window_d= own")))) >> + (delete 'configure) >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out"))) >> + (install-file "keynav" (string-append out "/bin")) >> + (install-file "keynavrc" (string-append out "/etc"))))))= )) > > Please return #t in each of these phases. OK, pushed as with a6a2ef27a389f5ff88b752ba56a7f34d94cb087b with: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: Applied suggestions diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm index 864ebb0a4..4bad8f23f 100644 --- a/gnu/packages/xorg.scm +++ b/gnu/packages/xorg.scm @@ -6147,12 +6147,13 @@ and embedded platforms.") (native-inputs `(("pkg-config" ,pkg-config))) (arguments - `(#:tests? #f + `(#:tests? #f ;No tests. #:phases (modify-phases %standard-phases (add-after 'unpack 'setenv (lambda _ - (setenv "CC" (which "gcc")))) + (setenv "CC" (which "gcc")) + #t)) (add-after 'unpack 'patch-keynav (lambda _ (substitute* "keynav.c" @@ -6167,13 +6168,15 @@ and embedded platforms.") (("xdo_mouselocation") "xdo_get_mouse_location") (("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move_to") (("xdo_keysequence_up") "xdo_send_keysequence_window_up") - (("xdo_keysequence_down") "xdo_send_keysequence_window_down")))) + (("xdo_keysequence_down") "xdo_send_keysequence_window_down")) + #t)) (delete 'configure) (replace 'install (lambda* (#:key outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) (install-file "keynav" (string-append out "/bin")) - (install-file "keynavrc" (string-append out "/etc")))))))) + (install-file "keynavrc" (string-append out "/etc"))) + #t))))) (home-page "https://www.semicomplete.com/projects/keynav/") (synopsis "Keyboard-driven mouse cursor mover") (description --=-=-= Content-Type: text/plain Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAls6/AcACgkQckbhHGm3 lWlBbg//XJR1O8GSBOU/D+L+xkOresbIrBLq+sdBCN6ngg1U+4/SHrbCTkedNWwS +2fm8sl70xQ2fQhzBPOTTjz9qtDQ36qijA8RIXrD7N0ue9jTj7sVsArdunJwaFUw SxhkKuJKFGwGodMP9dWakPTZc3NxccDqg1r7GioZpiDjd8GKP0lQQnnikf9ua6UC 8JHWXJpq8E6W+ux/2+BHaSJwKRteqtmhLd/Tmh/zfR7fnK+Py+cdBI70jp1Cn4SO wx6J1JHlhfS5C2etT51iUSH1s26X3TQxpvWtmk4iwztItlzc58a5WqvHCYDsa5sh aZ54hw8rpgJEyx6fGRfRMWfe3WAaFgwoSJkQ97px7NrE86FkUiZiMqS84X8JW/0+ KjmTqVewZyBaaYEfYCeoIuxQY8ss/tTjJ3yE2+twcgTbk90m/artKZQ0s0XMbCtm wurENGiyOWYMj+LcK316qJSXyyGAvAE+IswCHHhJQPJFoixB7SsnLu6B5lsPoqeV NvpodtlvLuQJ20LRUERenJwNjcWxrKZ3shqO9ZSCTWPpUcEN43y6MqvHvqma8CFm S/48LVqmC9uJajlq/Ey2XIBDwqvClgoX2nhjIYI6nxkWfYxcmebA9Jg4zb4McdKK DiAOtUO9eaYx5WcPssQEsC7snS0ppcZX544iONXm3IEREh5zDQg= =hHGL -----END PGP SIGNATURE----- --==-=-=--