[bug#32031] [PATCH] gnu: Add keynav.

[Oleg Pykhalov <go.wigust@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2055 bytes --]

Hello Ludovic,

Thank you for review.

ludo@gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> * gnu/packages/xorg.scm (keynav): New variable.
>
> [...]
>
>> +    (arguments
>> +     `(#:tests? #f
>
> Could you leave a comment explaining why tests are skipped?  If an X
> server is needed, we can launch Xvfb before the ‘check’ phase, as many
> packages do.

Ah, I should did this in the first place, sorry.  There are no tests.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'setenv
>> +           (lambda _
>> +             (setenv "CC" (which "gcc"))))
>> +         (add-after 'unpack 'patch-keynav
>> +           (lambda _
>> +             (substitute* "keynav.c"
>> +               (("xdo_symbol_map") "xdo_get_symbol_map")
>> +               (("xdo_window_setclass") "xdo_set_window_class")
>> +               (("xdo_window_get_active") "xdo_get_window_at_mouse")
>> +               (("xdo_click") "xdo_click_window")
>> +               (("xdo_mouseup") "xdo_mouse_up")
>> +               (("xdo_mousedown") "xdo_mouse_down")
>> +               (("xdo_mousemove") "xdo_move_mouse")
>> +               (("xdo_mousemove_relative") "xdo_move_mouse_relative")
>> +               (("xdo_mouselocation") "xdo_get_mouse_location")
>> +               (("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move_to")
>> +               (("xdo_keysequence_up") "xdo_send_keysequence_window_up")
>> +               (("xdo_keysequence_down") "xdo_send_keysequence_window_down"))))
>> +         (delete 'configure)
>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (install-file "keynav" (string-append out "/bin"))
>> +               (install-file "keynavrc" (string-append out "/etc"))))))))
>
> Please return #t in each of these phases.

OK, pushed as with a6a2ef27a389f5ff88b752ba56a7f34d94cb087b with:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Applied suggestions --]
[-- Type: text/x-patch, Size: 1630 bytes --]

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 864ebb0a4..4bad8f23f 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -6147,12 +6147,13 @@ and embedded platforms.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (arguments
-     `(#:tests? #f
+     `(#:tests? #f ;No tests.
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'setenv
            (lambda _
-             (setenv "CC" (which "gcc"))))
+             (setenv "CC" (which "gcc"))
+             #t))
          (add-after 'unpack 'patch-keynav
            (lambda _
              (substitute* "keynav.c"
@@ -6167,13 +6168,15 @@ and embedded platforms.")
                (("xdo_mouselocation") "xdo_get_mouse_location")
                (("xdo_mouse_wait_for_move_to") "xdo_wait_for_mouse_move_to")
                (("xdo_keysequence_up") "xdo_send_keysequence_window_up")
-               (("xdo_keysequence_down") "xdo_send_keysequence_window_down"))))
+               (("xdo_keysequence_down") "xdo_send_keysequence_window_down"))
+             #t))
          (delete 'configure)
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (install-file "keynav" (string-append out "/bin"))
-               (install-file "keynavrc" (string-append out "/etc"))))))))
+               (install-file "keynavrc" (string-append out "/etc")))
+             #t)))))
     (home-page "https://www.semicomplete.com/projects/keynav/")
     (synopsis "Keyboard-driven mouse cursor mover")
     (description

[-- Attachment #1.3: Type: text/plain, Size: 7 bytes --]


Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]