From: ludo@gnu.org (Ludovic Courtès) To: Leo Famulari <leo@famulari.name> Cc: 32872@debbugs.gnu.org, 30642@debbugs.gnu.org Subject: bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog. Date: Sun, 30 Sep 2018 00:05:56 +0200 [thread overview] Message-ID: <877ej4vu0r.fsf@gnu.org> (raw) In-Reply-To: <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name> (Leo Famulari's message of "Sat, 29 Sep 2018 08:56:50 -0400") Hi! Leo Famulari <leo@famulari.name> skribis: > Without this, LibreOffice crashes on a foreign distro when the "file > open" dialog is launched. I think there *must* be a better solution but > until we identify it, we should fix the crash. I'm Currently building > this to test it. > > * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program' > phase. You could mention <https://bugs.gnu.org/30642> in the log. One option discussed at the time was to use ‘glib-or-gtk-build-system’, which should have an effect similar to the patch you posted. Perhaps we should just do that? > + (add-after 'bin-and-desktop-install 'wrap-programs > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) Nitpick: the lambda’s body is too indented. :-) Thank you! Ludo’.
WARNING: multiple messages have this Message-ID (diff)
From: ludo@gnu.org (Ludovic Courtès) To: Leo Famulari <leo@famulari.name> Cc: 32872@debbugs.gnu.org, 30642@debbugs.gnu.org Subject: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog. Date: Sun, 30 Sep 2018 00:05:56 +0200 [thread overview] Message-ID: <877ej4vu0r.fsf@gnu.org> (raw) In-Reply-To: <8351ca4e6f107a0f20b0441507ecb6ab7aa30856.1538225757.git.leo@famulari.name> (Leo Famulari's message of "Sat, 29 Sep 2018 08:56:50 -0400") Hi! Leo Famulari <leo@famulari.name> skribis: > Without this, LibreOffice crashes on a foreign distro when the "file > open" dialog is launched. I think there *must* be a better solution but > until we identify it, we should fix the crash. I'm Currently building > this to test it. > > * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program' > phase. You could mention <https://bugs.gnu.org/30642> in the log. One option discussed at the time was to use ‘glib-or-gtk-build-system’, which should have an effect similar to the patch you posted. Perhaps we should just do that? > + (add-after 'bin-and-desktop-install 'wrap-programs > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) Nitpick: the lambda’s body is too indented. :-) Thank you! Ludo’.
next prev parent reply other threads:[~2018-09-29 22:07 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-29 12:56 [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog Leo Famulari 2018-09-29 22:05 ` Ludovic Courtès [this message] 2018-09-29 22:05 ` Ludovic Courtès 2018-09-30 11:42 ` bug#30642: " Leo Famulari 2018-09-30 11:42 ` Leo Famulari 2018-12-04 21:29 ` bug#30642: " Ludovic Courtès
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=877ej4vu0r.fsf@gnu.org \ --to=ludo@gnu.org \ --cc=30642@debbugs.gnu.org \ --cc=32872@debbugs.gnu.org \ --cc=leo@famulari.name \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.