From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBxv1-0003Mr-5p for guix-patches@gnu.org; Mon, 15 Oct 2018 04:08:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBxv0-0006kf-AY for guix-patches@gnu.org; Mon, 15 Oct 2018 04:08:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBxv0-0006kb-5t for guix-patches@gnu.org; Mon, 15 Oct 2018 04:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBxuz-0004OL-Ty for guix-patches@gnu.org; Mon, 15 Oct 2018 04:08:01 -0400 Subject: [bug#32933] [PATCH] guix: add license prefix hackage imports Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87h8hri9sj.fsf@gnu.org> <87a7nioqk6.fsf@elephly.net> Date: Mon, 15 Oct 2018 10:07:12 +0200 In-Reply-To: <87a7nioqk6.fsf@elephly.net> (Ricardo Wurmus's message of "Fri, 12 Oct 2018 22:31:05 +0200") Message-ID: <877eijljkf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 32933@debbugs.gnu.org Hello, Ricardo Wurmus skribis: >> The motivation was to be consistent with the `gnu/packages/haskell.scm` = which >> uses the `license:` prefix. I noticed this when I imported a bunch of pa= ckages >> and all of them were missing the prefix, which then had to be manually a= dded. >> >> On Fri, Oct 12, 2018 at 6:17 AM Ludovic Court=C3=A8s wrot= e: >>> >>> No strong opinion, but apparently none of the importers currently adds >>> the =E2=80=98license:=E2=80=99 prefix and I=E2=80=99d rather keep that = consistent, one way or >>> another. >> >> That's not entirely true. crate calls `spdx-string->license` which adds = the >> prefix, but it doesn't appear to actually work because it looks for the = license >> in the wrong part of the json output from crates.io. > > I have a slight preference to not adding the prefix. It is true that > most modules do use this prefix, but I think the importers should be > agnostic of that. Some modules don=E2=80=99t use this prefix (e.g. web.s= cm) or > no prefix at all (especially user modules that don=E2=80=99t exist yet). > > I=E2=80=99d rather have the importers be more flexible and do the right t= hing > dependent on context, but I have no good idea how to accomplish this > considering that they are used outside of any context (unless they were > called as part of an updater). Right, I sort of feel along the same lines. OTOH, the goal of =E2=80=98guix import=E2=80=99 is to provide templates as = close as possible to working package definitions. In that sense, if adding the =E2=80=98license:=E2=80=99 prefix lowers the barrier a little bit (and it c= ertainly does, as Joe wrote), the better. For the sake of consistency though, it may be best to do it for all the importers, if we were to take that route. WDYT, Ricardo? Thanks, Ludo=E2=80=99.