From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in) Date: Wed, 17 Oct 2018 20:24:51 -0400 Message-ID: <877eig14q4.fsf@netris.org> References: <20180925195720.nelxr55dy7ntupma@abyayala> <87k1n9cfpp.fsf@netris.org> <87y3aw9o3q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCw8c-0007b7-LW for bug-guix@gnu.org; Wed, 17 Oct 2018 20:26:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCw8Y-0006pV-Ht for bug-guix@gnu.org; Wed, 17 Oct 2018 20:26:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCw8X-0006kF-U7 for bug-guix@gnu.org; Wed, 17 Oct 2018 20:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gCw8X-00030F-N6 for bug-guix@gnu.org; Wed, 17 Oct 2018 20:26:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87y3aw9o3q.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 18 Oct 2018 00:59:05 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32840@debbugs.gnu.org, Nils Gillmann --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> Nils Gillmann writes: >> >>> at taler we need shpchp as a module in the initrd. >>> >>> Before version 4.18.x, shpchp was a module we've build in guix' linux-l= ibre, >>> you were able to just specify it for the initrd. >>> >>> With 4.18.9, this module became a compile-in/built-in (see linux >>> commit log). I want to avoid maintaining yet another kernel >>> definition for future complications if I can. Can we get this module >>> built in by default? >> >> Sure, that sounds sensible. I'll push a config update soon. > > I=E2=80=99ve reopened the bug because I think we need the same change as = in > fe73352e8073ea0a0e6f6b5591f24395671998ab for AArch64 (at least it > appears to be needed on the OverDrive 1000.) > > Could you take a look? Sure. I've attached a proposed patch below. Would you like to try it and push it to master if it works? > (I=E2=80=99m not entirely sure about the workflow to get the updated conf= ig from > =E2=80=9Cmake oldconfig=E2=80=9D=E2=80=A6) FYI, my current method is: * Unpack the latest linux-libre source. * Copy the existing kernel configuration to .config in the source dir. * Manually edit .config with desired configuration change. * Within "guix environment linux-libre" run: ARCH=3Darm64 make oldconfig More generally, ARCH should be set to the value returned by 'system->linux-architecture' in (gnu packages linux). * Manually edit out some changes that are clearly irrelevant, such the addition of a top comment saying which compiler I have in my PATH. Some day, I would prefer to have multiple smaller configuration files, with a shared common configuration plus smaller architecture-specific files, but we're not there yet. Thanks, Mark --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-linux-libre-Enable-SHPC-PCI-Hotplug-driver-on-AR.patch Content-Description: [PATCH] gnu: linux-libre: Enable SHPC PCI Hotplug driver on ARM64 >From 41fdb333b05e300622c4c41aaced70fff2c6df7f Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Wed, 17 Oct 2018 20:09:19 -0400 Subject: [PATCH] gnu: linux-libre: Enable SHPC PCI Hotplug driver on ARM64. Fixes on ARM64. * gnu/packages/aux-files/linux-libre/4.18-arm64.conf: Add CONFIG_HOTPLUG_PCI_SHPC=y. --- gnu/packages/aux-files/linux-libre/4.18-arm64.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/aux-files/linux-libre/4.18-arm64.conf b/gnu/packages/aux-files/linux-libre/4.18-arm64.conf index ab30f51d2..64b14b52c 100644 --- a/gnu/packages/aux-files/linux-libre/4.18-arm64.conf +++ b/gnu/packages/aux-files/linux-libre/4.18-arm64.conf @@ -1,6 +1,6 @@ # # Automatically generated file; DO NOT EDIT. -# Linux/arm64 4.18.0-gnu Kernel Configuration +# Linux/arm64 4.18.14-gnu Kernel Configuration # CONFIG_ARM64=y CONFIG_64BIT=y @@ -481,7 +481,7 @@ CONFIG_HOTPLUG_PCI=y CONFIG_HOTPLUG_PCI_ACPI=y CONFIG_HOTPLUG_PCI_ACPI_IBM=m CONFIG_HOTPLUG_PCI_CPCI=y -# CONFIG_HOTPLUG_PCI_SHPC is not set +CONFIG_HOTPLUG_PCI_SHPC=y # # PCI controller drivers -- 2.19.1 --=-=-=--