From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39390)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaMZs-0004iV-C3
	for guix-patches@gnu.org; Fri, 21 Dec 2018 10:19:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaMZr-0006js-H3
	for guix-patches@gnu.org; Fri, 21 Dec 2018 10:19:04 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54402)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gaMZq-0006iU-DD
	for guix-patches@gnu.org; Fri, 21 Dec 2018 10:19:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaMZq-0006Di-4o
	for guix-patches@gnu.org; Fri, 21 Dec 2018 10:19:02 -0500
Subject: [bug#33801] import: github: Support source URIs that redirect to
	GitHub
Resent-Message-ID: <handler.33801.B33801.154540551623871@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <cu7imzpokxn.fsf@systemreboot.net> <87d0pxtciz.fsf@gnu.org>
	<cu7mup04rfp.fsf@systemreboot.net> <87woo4qxg7.fsf@gnu.org>
	<cu77eg44a9f.fsf@systemreboot.net> <87k1k4p3gl.fsf@gnu.org>
	<cu7h8f8b0vc.fsf@systemreboot.net> <cu77eg3awvc.fsf@systemreboot.net>
Date: Fri, 21 Dec 2018 16:18:27 +0100
In-Reply-To: <cu77eg3awvc.fsf@systemreboot.net> (Arun Isaac's message of "Fri,
	21 Dec 2018 17:57:03 +0530")
Message-ID: <877eg2q56k.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33801@debbugs.gnu.org

Hello!

Arun Isaac <arunisaac@systemreboot.net> skribis:

> From 65c540c549c1f2a415b54ccc04dec4b1406bb5eb Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Fri, 21 Dec 2018 17:48:55 +0530
> Subject: [PATCH] guix: lint: Check for source URIs redirecting to GitHub.
>
> * guix/scripts/lint.scm (check-github-uri): New procedure.
> (%checkers): Add it.

Overall LGTM.  Two things:

  1. Could you add tests in tests/lint.scm?  You can use the same
     strategy as the the =E2=80=98source=E2=80=99 tests there.  Let me know=
 if you have
     questions.

  2. Could you add it to doc/guix.texi?

Thank you!

Ludo=E2=80=99.