From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#33896: libblockdev inputs are not used correctly
Date: Sat, 05 Jan 2019 18:55:52 +0100
Message-ID: <877efj2dlj.fsf@gnu.org>
References: <20181228143255.78bf15b1@scratchpost.org>
	<20181229185036.GV2581@macbook41>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggsout.gnu.org ([209.51.188.92]:55777 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfqB5-0006pQ-KO
	for bug-guix@gnu.org; Sat, 05 Jan 2019 12:56:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfqB0-0007Zk-KM
	for bug-guix@gnu.org; Sat, 05 Jan 2019 12:56:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:44289)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gfqB0-0007ZX-Fv
	for bug-guix@gnu.org; Sat, 05 Jan 2019 12:56:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gfqB0-0005xx-DH
	for bug-guix@gnu.org; Sat, 05 Jan 2019 12:56:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33896.B33896.154671095822923@debbugs.gnu.org>
In-Reply-To: <20181229185036.GV2581@macbook41> (Efraim Flashner's message of
	"Sat, 29 Dec 2018 20:50:36 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 33896@debbugs.gnu.org

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Fri, Dec 28, 2018 at 02:32:55PM +0100, Danny Milosavljevic wrote:
>> Currently, libblockdev has inputs which aren't used.
>>=20
>> These SHOULD be used, but the source files are not patched
>> so the executables in the inputs are not found or used.
>>=20
>> Example:
>>=20
>> * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would =
use
>> "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually re=
fer
>> to the inputs.
>>=20
>> This problem is valid for everything in src/plugins/fs .
>>=20
>> Do we proceed to patch it to use the inputs or do we move dosfstools etc
>> to propagated-inputs ?
>>=20
>> I'd suggest the former.
>
> Similar to the enlightenment package getting more 'substitute*'s to
> improve functionality, I agree that patching libblockdev to actually
> find all the inputs/executables is preferable.

I agree; using =E2=80=98substitute*=E2=80=99 is more appropriate than propa=
gation here.

Thanks,
Ludo=E2=80=99.