From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm5M1-00023x-B5 for guix-patches@gnu.org; Tue, 22 Jan 2019 18:21:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm5CB-0007MG-CU for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm5CA-0007Lt-FW for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gm5CA-0008G1-6R for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:02 -0500 Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support Resent-Message-ID: References: <87zhrx4mlu.fsf@web.de> <87lg3cjrdh.fsf@gnu.org> From: Arne Babenhauserheide In-reply-to: <87lg3cjrdh.fsf@gnu.org> Date: Wed, 23 Jan 2019 00:10:41 +0100 Message-ID: <877eew70ge.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34128@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, > Thanks for the patch! Thank you for your review! > I wonder why this hadn=E2=80=99t been done before; > Nicolas, Alex, Pierre, thoughts? There is an older bug with xwidgets support which had problems because it depended on an old version of webkitgtk (I only found it after I sent the patch). Maybe that stopped others from submitting. Ludovic Court=C3=A8s writes: > The patch LGTM, minor stylistic issues: > =E2=80=A6 > Please indent rather along these lines (like in the rest of the file): > > (define-public emacs-xwidgets > (package > (inherit emacs) > (name =E2=80=A6) =E2=80=A6)) > > Likewise, for consistency, use unquote-splicing rather than =E2=80=98appe= nd=E2=80=99: > > (inputs `(("webkitgtk" ,webkitgtk) > ;; =E2=80=A6 > ,@(package-inputs emacs))) > > Could you send an updated patch? Is inline here OK? If yes: From=20ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Fri, 18 Jan 2019 23:29:14 +0100 Subject: [PATCH] add emacs built with xwidgets-support * gnu/packages/emacs.scm (emacs-xwidgets): new variable =2D-- gnu/packages/emacs.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index a488289f1..7e8dcadf9 100644 =2D-- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -59,6 +59,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages texinfo) #:use-module (gnu packages tls) + #:use-module (gnu packages webkit) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (guix utils) @@ -210,6 +211,22 @@ languages.") (native-inputs `(("pkg-config" ,pkg-config))))) =20 +(define-public emacs-xwidgets + (package + (inherit emacs) + (name "emacs-xwidgets") + (synopsis "The extensible, customizable, self-documenting text +editor (with xwidgets support)") + (build-system gnu-build-system) + (arguments + `(#:configure-flags + '("--with-xwidgets") + ,@(package-arguments emacs))) + (inputs + `(("webkitgtk" ,webkitgtk) + ("libxcomposite" ,libxcomposite) + ,@(package-inputs emacs))))) + (define-public emacs-no-x (package (inherit emacs) (name "emacs-no-x") =2D-=20 2.19.2 Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein ohne es zu merken --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAlxHovIACgkQE++NRSQD w+vTLw//a1P5koIGpdIB0kDNA4yuFCw2uhLU2WKDRmjfMg0mlyCP23UHS3j8kuLm aWZeuGBMo9Nd9vhdpDb59UX4oeWyTAcDxvn244+NBZWy8A1REGmU9U4nt2d/3nhh BjKK0ELrMGUOpTfMMYcv2ldpxyMhI2y3VMH8Z5XUmv1BCZoDPrxIzteopwF3Xq33 Kn14/GzzFkhO77p6AuJiukgXWDfcI98CMnp8QuGIxXThpBSqS2cicCeMPX69mahl z7UgjeSbK1F5F71VAuaadVlAGS9KBFE+8ypSnhXFUxU/ekt2G7wmNHnP7Jg9conV GI6JaWpQtcrZNmroTD+hvnBbH7fVkpQj9PWiIBEzV5uFVqGAAAH46R0oEgL+OD5D c4Og8cHVdFFF4+i88x1HNF5Dps862fmSlpLj3vOOpon6bpv2A6QeT2+eeEBa6Bvr qL9SzoLydiDasfXi60IN1P4QdkUMGNfU68ivu0R1OolysYa2UmCIfitKZ3MM9LER 5bhKeTlFcOu3BEE/4Jz29kDoCjZEGSGfmHbf6Q4rC/lISEZb/tBiBf28gzfqolYS nzQNj6I1Nw+YSUkUdyx4eNziywlwWIF/adocjD0l6G39EmE1fhB7YZAKaUIPRUGq 8VmHBRDROGhuHV++sCJ9OQL+NLCMYvFkUQQtQ49ohkmlpOsaPLyIswQBAQgAHRYh BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJcR6LyAAoJENzPDbMLwQVIMlQEAIOGAX0/ GWl/GXrVF+ELIxWIY0CQ0fwtRZS2Mr4TG53+nWeW59EPaJjWukZnhX9kgrF+HL4F ens9JW9YeQzD3D5oJljWmvPds0kkkfDOWBTkQyEKHfP+WahGrAtGm0lD6oumTXP7 bHLPNLJPa5QbAxWH1LpC6XOowb+sfbvz8QXM =uA+/ -----END PGP SIGNATURE----- --=-=-=--