From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:40578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnOpV-0003Gu-Kg
	for guix-patches@gnu.org; Sat, 26 Jan 2019 09:21:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnOpT-0004Tl-NG
	for guix-patches@gnu.org; Sat, 26 Jan 2019 09:21:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:46641)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gnOpS-0004QQ-16
	for guix-patches@gnu.org; Sat, 26 Jan 2019 09:21:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gnOpR-0007eB-SH
	for guix-patches@gnu.org; Sat, 26 Jan 2019 09:21:01 -0500
Subject: [bug#34204] [PATCH 1/3] gnu: python-tornado: Update to 5.1.1.
Resent-Message-ID: <handler.34204.B34204.154851240629314@debbugs.gnu.org>
References: <20190126002545.7589-1-mthl@gnu.org>
	<20190126002849.7707-1-mthl@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190126002849.7707-1-mthl@gnu.org>
Date: Sat, 26 Jan 2019 14:34:14 +0100
Message-ID: <877eerv8yx.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: 34204@debbugs.gnu.org


Hi Mathieu,

> * gnu/packages/python-web.scm (python-tornado): Update to 5.1.1.

Thanks for the patch!

>  (define-public python-tornado
>    (package
>      (name "python-tornado")
> -    (version "4.5.1")
> +    (version "5.1.1")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "tornado" version))
>         (sha256
> -        (base32 "1zbkgcdfq81k298awrm8p0xwbwwn2p3nbizdglzfbkskhai082fv"))=
))
> +        (base32 "02clqk2116jbnq8lnaqmdw3p52nqrd9ib59r4xz2ll43fpcmhlaf"))=
))
>      (build-system python-build-system)
>      (arguments
>       '(;; FIXME: Two tests error out with:

The arguments field says:

    (arguments
     '(;; FIXME: Two tests error out with:
       ;; AssertionError: b'Error in atexit._run_exitfuncs:\nFileNotF[44 ch=
ars]ry\n' !=3D b''
       ;; #:phases
       ;; (modify-phases %standard-phases
       ;;   (replace 'check
       ;;     (lambda _
       ;;       ;; 'setup.py test' hits an AssertionError on BSD-specific
       ;;       ;; "tornado/platform/kqueue.py". This is the supported meth=
od:
       ;;       (invoke- "python" "-m" "tornado.test")
       ;;       #t)))
       #:tests? #f))

Is this still the case or can we enable the tests?

A number of important packages depend on python-tornado, such as
python-matplotlib, jupyter, and python-scikit-image.  Since this is a
major version bump I wonder if you have tried building some of these
related packages to make sure they don=E2=80=99t fail.

(We can of course respond to breakage once we discover it when building
the new evaluations, but it would be nicer if we could have some
reassurance.)

--=20
Ricardo