From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:42751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goFAI-0003uR-U3
	for guix-patches@gnu.org; Mon, 28 Jan 2019 17:14:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goFAI-00065N-8Y
	for guix-patches@gnu.org; Mon, 28 Jan 2019 17:14:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:50314)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1goFAI-00064y-4Y
	for guix-patches@gnu.org; Mon, 28 Jan 2019 17:14:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goFAH-0008HS-TK
	for guix-patches@gnu.org; Mon, 28 Jan 2019 17:14:01 -0500
Subject: bug#34153: [PATCH] Update fish to 3.0.0.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.34153.D34153.154871361131777.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <8736pm2zji.fsf@disroot.org>
Date: Mon, 28 Jan 2019 23:13:21 +0100
In-Reply-To: <8736pm2zji.fsf@disroot.org> (Meiyo Peng's message of "Mon, 21
	Jan 2019 16:19:29 +0800")
Message-ID: <877eeoo2gu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Meiyo Peng <meiyo@disroot.org>
Cc: 34153-done@debbugs.gnu.org

Hello Meiyo,

Meiyo Peng <meiyo@disroot.org> skribis:

> This patch series updates fish shell to 3.0.0 and enable fish to source
> /etc/profile using fish-foreign-env.

I don=E2=80=99t use Fish so I don=E2=80=99t really have an opinion but it l=
ooks
reasonable to me.  If it breaks, users will yell at you anyway.  ;-)

>>>From 8d20b9d62d0d6c6c9c572b5871d0063c8b4fdf07 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 6 Jan 2019 22:11:36 +0800
> Subject: [PATCH 1/3] gnu: fish: Update to 3.0.0.
>
> * gnu/packages/shells.scm (fish): Update to 3.0.0.
>   [source]: Remove dead URL.
>   [inputs]: Remove bc.  Replace python-wrapper with python.
>   [arguments]: Remove configure-flags.  Enable fish to source
>   /etc/fish/config.fish.  Enable completions, functions and configurations
>   in user's and system's guix profiles.

[...]

>>>From da8487fe9b9a0a0308f7b929f9e95e8e8297de26 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 20 Jan 2019 21:41:21 +0800
> Subject: [PATCH 2/3] gnu: Add fish-foreign-env.
>
> * gnu/packages/shells.scm (fish-foreign-env): New variable.

[...]

>>>From aadeb9dea8aff0db8a339cc11d006abff4736fdb Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 20 Jan 2019 21:42:15 +0800
> Subject: [PATCH 3/3] gnu: fish: Use fish-foreign-env to source /etc/profi=
le.
>
> * gnu/packages/shells.scm (fish): Use fish-foreign-env to source /etc/pro=
file
>   when user logs in.

Applied all three patches.  Thanks for working on it!

Ludo=E2=80=99.