From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 02/04: monads, gexp: Prevent redefinition of syntax parameters.
Date: Thu, 07 Feb 2019 08:50:13 +0100 [thread overview]
Message-ID: <877eecf362.fsf@elephly.net> (raw)
In-Reply-To: <20190206220625.8BB03209A7@vcs0.savannah.gnu.org>
guix-commits@gnu.org writes:
> civodul pushed a commit to branch master
> in repository guix.
>
> commit 8245bb74fc7bdcdc2f9d458057cefc9cd982e489
> Author: Ludovic Courtès <ludo@gnu.org>
> Date: Wed Feb 6 21:58:43 2019 +0100
>
> monads, gexp: Prevent redefinition of syntax parameters.
>
> Fixes <https://bugs.gnu.org/27476>.
>
> This fixes multi-threaded compilation of this code where syntax
> parameters could end up being redefined and where a race condition could
> lead a thread to see the "wrong" value of the syntax parameter.
>
> * guix/monads.scm (define-syntax-parameter-once): New macro.
> (>>=, return): Use it.
> * guix/gexp.scm (define-syntax-parameter-once): New macro.
> (current-imported-modules, current-imported-extensions): Use it.
Oh yeah!
Thank you so much for squashing this bug (and all of those it was merged
with)!
--
Ricardo
parent reply other threads:[~2019-02-07 8:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190206220625.8BB03209A7@vcs0.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eecf362.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.