From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:42535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hG9sW-0003SG-De
	for guix-patches@gnu.org; Mon, 15 Apr 2019 18:15:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hG9sV-0007kF-Fu
	for guix-patches@gnu.org; Mon, 15 Apr 2019 18:15:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:50377)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hG9sV-0007k6-AX
	for guix-patches@gnu.org; Mon, 15 Apr 2019 18:15:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hG9sT-0006TA-LA
	for guix-patches@gnu.org; Mon, 15 Apr 2019 18:15:03 -0400
Subject: [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies and
	enable docker-proxy.
Resent-Message-ID: <handler.35281.B35281.155536647624816@debbugs.gnu.org>
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
References: <87muksnqaq.fsf@gmail.com>
	<20190415082226.03761fcc@scratchpost.org>
Date: Mon, 15 Apr 2019 18:14:25 -0400
In-Reply-To: <20190415082226.03761fcc@scratchpost.org> (Danny Milosavljevic's
	message of "Mon, 15 Apr 2019 08:22:26 +0200")
Message-ID: <877ebuncfy.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35281@debbugs.gnu.org

Hi Danny!

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> On Sun, 14 Apr 2019 19:02:53 -0400
> Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> +         ;; The tests fail with the error:
>> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
>> +         ;; has arg n.configOnly of wrong type bool.
>> +         #:tests? #f))
>> +      (home-page "https://github.com/docker/libnetwork/")
>
> It might make sense to report that bug upstream--they're helpful people.
>
> Otherwise LGTM!

Thanks for bringing my attention to that part; I've tried re-enabling
the tests but it seems to fail because of unmet dependencies now --
which makes sense since I'm not adding any inputs.  I've removed the
tests? #f argument and detailed in the top comment that this is simply
used as a template and doesn't even build.

Thanks for the review!

Maxim