From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41756)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hvQp2-0007mI-0v
 for guix-patches@gnu.org; Wed, 07 Aug 2019 14:38:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hvQp1-0004sM-1u
 for guix-patches@gnu.org; Wed, 07 Aug 2019 14:38:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58767)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hvQp0-0004og-2s
 for guix-patches@gnu.org; Wed, 07 Aug 2019 14:38:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hvQoz-0005xU-Qe
 for guix-patches@gnu.org; Wed, 07 Aug 2019 14:38:01 -0400
Subject: [bug#36962] [PATCH] gnu: Add network-manager-openconnect.
Resent-Message-ID: <handler.36962.B36962.156520305022848@debbugs.gnu.org>
References: <20190807170450.2996-1-efraim@flashner.co.il>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190807170450.2996-1-efraim@flashner.co.il>
Date: Wed, 07 Aug 2019 20:37:19 +0200
Message-ID: <877e7oyg80.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36962@debbugs.gnu.org


Hi Efraim,

> * gnu/packages/gnome.scm (network-manager-openconnect): New variable.

This looks good to me.

Why is this in gnome.scm and not in, say, networking?

> +               (substitute* "src/nm-openconnect-service.c"
> +                    (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
> +                    (("\"/usr/sbin/openconnect\"") pretty-ovpn)
> +                    (("/sbin/modprobe") modprobe)))

The indentation looks wrong.

-- 
Ricardo