From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46749) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXYau-0006F6-QO for guix-patches@gnu.org; Wed, 20 Nov 2019 17:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXYat-0001rY-Lk for guix-patches@gnu.org; Wed, 20 Nov 2019 17:37:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXYat-0001rP-GL for guix-patches@gnu.org; Wed, 20 Nov 2019 17:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXYar-0005kT-PQ for guix-patches@gnu.org; Wed, 20 Nov 2019 17:37:03 -0500 Subject: [bug#38279] [PATCH 1/1] gnu: sdl: Add libxcursor to propagated-inputs. Resent-Message-ID: From: Oleg Pykhalov References: <20191119181425.23755-1-go.wigust@gmail.com> <20191119182300.24622-1-go.wigust@gmail.com> <20191119210036.GR15074@E5400> Date: Thu, 21 Nov 2019 01:35:53 +0300 In-Reply-To: <20191119210036.GR15074@E5400> (Efraim Flashner's message of "Tue, 19 Nov 2019 23:00:36 +0200") Message-ID: <877e3u9nw6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner , Marius Bakke Cc: 38279@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Efraim Flashner writes: > This increases the size of 'guix size sdl' from 491.1MiB to 491.2. Do we > need anything similar for sdl2? I tried to fix sdl2. Do you mean =E2=80=98sdl=E2=80=99? I tried to run tu= xpaint which was build from our Guix package collection and sdl version 1. The cursor is black, so I cannot say is it broken or not. Also I checked other =E2=80=98sdl=E2=80=99 games, but no custom cursor ther= e, too: meritous, knights, prboom-plus, lierolibre, chromium-bsu, tuxpaint, kobodeluxe, enigma. NIX's SDL package doesn't contain libXcursor input, but SDL2 does contain. I think we should follow this decision. I worry about qemu and other sdl2 dependent packages. Should the patch be merged to core-updates? Marius Bakke writes: > Woow, nice find. The patch LGTM, but please add a comment in the code > about why it has to be propagated, along the lines of "Enable X11 cursor > support in dependent programs, see ". Sure. I'll add =E2=80=9CEnable X11 cursor support in dependent programs=E2= =80=9D above =E2=80=98("libxcursor" ,libxcursor)=E2=80=99. Also I'll place the libxcurs= or to =E2=80=98inputs=E2=80=99 instead of =E2=80=98propagated-inputs=E2=80=99 of = SDL2 package, because it's enough as I tested. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl3Vv8kACgkQFn+OpQAa +px+Sw/+KeCXhN6p9P8pCnzyu+ljC1FVXVUAeuz9pJzJ4whgF9SBb/mU/9JpgFRb 2aUcSGH9PRdpwdPDvA2yj5n0xA0lRkaJhc2Ozf+W3QTQoFd25Qh8I/viIdEMNxlC jRqCcGJAU69P09goDH0cpyP+o7SYsxvdsbmi6P8xgsvKMLgxzre+ca4IWb88bUpC YpAFaGVWBj9r+t5RFCqrMPlbC4v51MdcG/aa1rSwK4tSWSsK86H1DOQR+ZjcI5xj e35jw/EG8pKXfddxcVIW2eMPgwDJkPv+LSSAczDuVVvm39kepyyM/zCf9I7+SYfZ BKzOBDwDwiIEonhIjUej/I3Yh9/7JCieuxz3ReqDgx0vR2WOUek091sjJeEnrX9o ePBaK1ZQQR9l3z6MMoyRPQsRrfX94B3xnao+xvlILSw761bOue4ecf3+KikcWA7t esonsyHZRR86KcfAfzQdMPOn6HBVe3+hWpLQpApUbN6uwPvGxC2I5S4WkplJD5oZ xOIwUSghxjbdf7nRB2MJp7I4W596dOxcdnCJY1DZ6lS4Lo3Ayvpm4vXT97aCAM0w 1iBVfowwVcXmlyCKBc3YjJyiDGY2cmiUsw8M9GM8S7Vs9QHLLzJFOboJXnkO0zva fduLTJG1nxYz4n5v0gQ1TRu5wmyXvWVP8PO6VyJpSfcENyd/LHE= =vbzB -----END PGP SIGNATURE----- --=-=-=--