From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieXUF-0006o1-2S for guix-patches@gnu.org; Mon, 09 Dec 2019 23:51:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieXUD-0008Tn-SX for guix-patches@gnu.org; Mon, 09 Dec 2019 23:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48737) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieXUD-0008Td-MY for guix-patches@gnu.org; Mon, 09 Dec 2019 23:51:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieXUD-0006tb-LH for guix-patches@gnu.org; Mon, 09 Dec 2019 23:51:01 -0500 Subject: [bug#38103] Dracula emacs theme Resent-Message-ID: From: Brett Gilio References: <87r22j4vvs.fsf@smtp.gmail.com> <87a795xbc6.fsf@thinkpad.i-did-not-set--mail-host-address--so-tickle-me> <87o8xjlca6.fsf@devup.no> Date: Mon, 09 Dec 2019 22:50:17 -0600 In-Reply-To: <87o8xjlca6.fsf@devup.no> (Marius Bakke's message of "Sun, 10 Nov 2019 21:14:09 +0100") Message-ID: <877e34n5rq.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: bluekeys@bluekeys.eu, 38103@debbugs.gnu.org Marius Bakke writes: > bluekeys@bluekeys.eu writes: > >> Hi, >> >> Second attempt to attach the patch. > > Looks good! > > [...] > >> +(define-public emacs-dracula-theme >> + (package >> + (name "emacs-dracula-theme") >> + (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517")) >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/dracula/emacs.git") >> + (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))) > > Could add a (let (commit ...)) binding for the commit hash so we don't > have to repeat it twice? See the surrounding packages for examples. > > Please also add a 'file-name' field here. > >> + (sha256 >> + (base32 >> + "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn")))) >> + (build-system emacs-build-system) >> + (home-page "https://draculatheme.com/emacs") >> + (synopsis "A dark theme for emacs") > > Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'. > >> + (description >> + "A dark theme for emacs and 50+ apps") > > Can you expand a bit on the "50+ apps" part? Perhaps something along > the lines of "Dracula is a dark color theme implemented for more than 50 > different applications. This package provides the Emacs theme." > > Can you send an updated patch? Thanks, and welcome! :-) > Hi Marius and bluekeys! I just wanted to bump this so we can get it pushed. If you would like some help, bluekeys please do not hesitate to ask us either here or on the #guix Freenode IRC. Also, when you send your revised patch do include yourself in the copyright section of the header! You deserve that designation for your contribution. Thanks! -- Brett M. Gilio Homepage -- https://scm.pw/ GNU Guix -- https://guix.gnu.org/