From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46916) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1wC6-0001vJ-Vc for guix-patches@gnu.org; Wed, 12 Feb 2020 12:53:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1wC5-000398-UD for guix-patches@gnu.org; Wed, 12 Feb 2020 12:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1wC5-00038v-Mu for guix-patches@gnu.org; Wed, 12 Feb 2020 12:53:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1wC5-0006d5-KU for guix-patches@gnu.org; Wed, 12 Feb 2020 12:53:01 -0500 Subject: [bug#39576] qdbm: fix segfault during test Resent-Message-ID: Message-ID: <877e0rg0c5.fsf@nckx> References: <20200212.161457.1945473684782544947.post@thomasdanckaert.be> In-reply-to: <20200212.161457.1945473684782544947.post@thomasdanckaert.be> Date: Wed, 12 Feb 2020 18:52:20 +0100 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 39576@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Thomas, Thomas Danckaert =E5=86=99=E9=81=93=EF=BC=9A > at some point, the package qdbm started running into a segfault=20 > during the test suite. This small patch fixes that. > > If it's ok, I can push the commit myself (I believe I still have=20 > commit rights), but since I haven't contributed in 2 years, I=20 > wanted=20 > to check if the patch meets all the requirements... Glad to hear you're still a Guixer. You're listed as =E2=80=98inactive=E2=80=99[0], but TBH I don't know what t= hat=20 means. If you're unable to push and/or interested in reactivating=20 your account, let us know. > - `( #:configure-flags (list (string-append=20 > "LDFLAGS=3D-Wl,-rpath=3D" > - (assoc-ref=20 > %outputs "out") > - "/lib")))) > + `(#:configure-flags (list (string-append=20 > "LDFLAGS=3D-Wl,-rpath=3D" > + (assoc-ref=20 > %outputs "out") > + "/lib")) I'd add a short =E2=80=98Fix a segmentation fault in the test suite=E2=80= =99=20 comment here. > + #:make-flags '("CFLAGS=3D-fPIC"))) Sticking to one idiom (list =E2=80=A6) is slightly newbie-friendlier, but=20 LGTM either way. Thanks! T G-R [0]: https://savannah.gnu.org/project/memberlist.php?group=3Dguix --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5EO1QACgkQ2Imw8BjF STw0Bg/+NtMg2OtHuEMchwMA0qb9Q/T4A0+i4IPFclbSgl2se3nhl2xNA5kcIOAY VmRLH611W8MXfnq3o84I7YXTJPnC/A59/y0IyW0r2MaJSEvo5BGq1ym40s72KYoI EOTd7nEVClZNu4oKJUrY6IM+dEwXcVK2QPcUkn6sh1wrXHlZsXyKRrpEasRnCLEw HFpOV5qpV9Ia4uATwxqvCCLXAZNUuUdnBgUQIjSUEExaMN+qtjoKOly1V9hpdGCs j8Qd8qKrMruuEERpJvB/KilVx7haewBIRnoZozHwLbaXTNZnyGiGSIerwDOLEAdJ UUd/z4OBixpW9bknFwZgHvVrci1gEr6TDotUW+pl3/EdHkSGiVdlfFR3/9BQgSDr 3xs6U0X4KFaZNtbv7eR3AS/et5N7NlCmJOxWR88TE9sXDQjHXqOh0wQmDd2Wnutg QE0+C/rl1Z0M5eqJazYhuxEm54t9Cqmngpj98dXglI96QCl/YGXaCu3l7I0CEutt 2rzUc9LQ3GEX0NjFlkT3t7ukepwRDqjE8cVcDTPOFP/4TLUXFOclVe7baF2uxrEq cBv08VuVh2WieFoAV1hKEAxrzAvUfJF+BuCVeML6OifaG8D0qPFMIEKH8wvEodp6 xdOCYTmcz4rqoWDgBLNT16mHOmiLh17JWzfaJheOBhoxa9ltjvI= =5Wp8 -----END PGP SIGNATURE----- --=-=-=--