From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54719) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5W8R-0004d5-K1 for guix-patches@gnu.org; Sat, 22 Feb 2020 09:52:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5W8Q-0004yu-MW for guix-patches@gnu.org; Sat, 22 Feb 2020 09:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42772) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5W8Q-0004yi-8X for guix-patches@gnu.org; Sat, 22 Feb 2020 09:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5W8Q-0003RB-7r for guix-patches@gnu.org; Sat, 22 Feb 2020 09:52:02 -0500 Subject: [bug#39730] [PATCH 0/2] Add cl-lquery Resent-Message-ID: References: <87pne7eeam.fsf@bendersteed.tech> <87v9nzrlks.fsf@yamatai> From: Dimakakos Dimos In-reply-to: <87v9nzrlks.fsf@yamatai> Date: Sat, 22 Feb 2020 16:51:24 +0200 Message-ID: <877e0eu13n.fsf@bendersteed.tech> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 39730-done@debbugs.gnu.org Cc: Guillaume Le Vaillant Guillaume Le Vaillant writes: > Instead of building 'version' and 'file-name' using 'string-append', you > can use the 'git-version' and 'git-file-name' functions. > I also put the 'fiveam' dependency of sbcl-lquery in 'native-inputs' > instead of 'inputs' as it's only used in the tests. Thanks for the corrections, I didn't know about git-version and git-file-name. I was sure that fiveam was in native inputs, was surprised to see it there, that's strange. Maybe an I sent an earlier patch series? And thanks again for pushing the patch!