From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: branch master updated (0aa0e1f -> 9b7f9e6) Date: Mon, 24 Feb 2020 22:22:24 +0100 Message-ID: <877e0bk7e7.fsf@ambrevar.xyz> References: <20200224101817.20439.52918@vcs0.savannah.gnu.org> <87blpom285.fsf@gnu.org> <87v9nvg1wf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57048) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6LBO-0000YU-Mb for guix-devel@gnu.org; Mon, 24 Feb 2020 16:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6LBN-0007my-8s for guix-devel@gnu.org; Mon, 24 Feb 2020 16:22:30 -0500 In-Reply-To: <87v9nvg1wf.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= , zimoun Cc: Guix Devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > More accurately, I think there was no consensus around the proposed > changes. Ricardo and I argued in favor of honoring =E2=80=98INSIDE_EMACS= =E2=80=99 and > disabling colors when it is set. > > In terms of process, I think it=E2=80=99s a case where we should make sur= e the > people involved in the discussion can come to an agreement before going > further (info "(guix) Commit Access"). > > WDYT? I believe that all points have been answered and I waited one week as usual. > As I wrote elsewhere, we avoid working around terminal bugs in Guix > itself. In this case, the bugs are in an old VTE version and about to > be fixed in Eshell, both of which are good reasons not to try to paper > over it in Guix. None of the changes that I pushed deal with the terminal bugs or with the Eshell bug. This is a separate issue. > I see reluctance to the proposed changes in > (I > agree with Ricardo=E2=80=99s concerns). I've addressed Ricardo's points: =2D M-x shell font-locking is not influenced by the colors of the programs being executed. M-x shell supports ANSI colors and it's expected of programs to display colors. =2D PAGER=3Dcat does not do the job as we discussed later. I believe the changes I pushed are going in the right direction. Please let me know if this introduced a regression. Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5UPpAACgkQm9z0l6S7 zH9X1Qf5AbkNptzUU6Om6j17Q8IOSUK8gWzQ0fdKc/xmt6PbN30Fxz3tfeQ/SqeG Gm5FRbFwyLZHwE0jfN6gKicRuIDmAvcrTDFNUtz156TbBeg2h9Ky4eZgpQuoGMJM Rvw15a8pLVmHXfsKn5PLLJzOtVTaeyaZj4cLwoCXY6RnIZUcMyxp3R4knqmaEt7e eexmgvvrVJhuwOg1rhVUbGGYQ08w9rq+sG82/s2mmH1iAhsPVQeOC9B2KSPf2nVK SI0r1KDBxANXMGKtMazhkKDt7dqjg+s5BBw2uo8yiDW2GSaSkqXSXXpNfTJbZDGE oU2sIOTlco0MHdVfQNnYxWG0eAI1KA== =Z3Lp -----END PGP SIGNATURE----- --=-=-=--