all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: 40218@debbugs.gnu.org
Subject: [bug#40218] linux-libre patch to support pinebook pro
Date: Tue, 24 Mar 2020 20:43:13 -0700	[thread overview]
Message-ID: <877dz914mm.fsf@yucca> (raw)
In-Reply-To: <87a74516fx.fsf@yucca>

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

On 2020-03-24, Vagrant Cascadian wrote:
> The one reason I haven't pushed the patch is it would cause useless
> rebuilds of linux-libre for x86_64, i686 and armhf; I've been trying to
> make that conditional for aarch64 and not been very successful at it; if
> someone could help with that, or give me the go-ahead to merge as is
> ... that'd be great!

FWIW, this is one of the permutations I've tried so far:

--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -432,12 +432,16 @@ corresponding UPSTREAM-SOURCE (an origin), using
the given DEBLOB-SCRIPTS."

 (define-public linux-libre-5.4-source
   (source-with-patches linux-libre-5.4-pristine-source
-                       (list %boot-logo-patch
-                             %linux-libre-arm-export-__sync_icache_dcache-patch
-                             ;; Pinebook Pro patch from linux-next,
-                             ;; can be dropped for linux-libre 5.7
-                             (search-patch
-                              "linux-libre-Add-initial-support-for-Pinebook-.patch"))))
+                       (cons* %boot-logo-patch
+                             %linux-libre-arm-export-__sync_icache_dcache-patch
+                             (if (let ((system (or
   (%current-target-system)
+                                                   (%current-system))))
+                                   (string-prefix? "aarch64" system))
+                                 ;; Pinebook Pro patch from linux-next,
+                                 ;; can be dropped for linux-libre 5.7
+                                 '((search-patch
+                                    "linux-libre-Add-initial-support-for-Pinebook-.patch"))
+                                 '()))))

 (define-public linux-libre-4.19-source
   (source-with-patches linux-libre-4.19-pristine-source


But with this, I get the source without the patch applied in all
cases...

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2020-03-25  3:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  3:04 [bug#40218] linux-libre patch to support pinebook pro Vagrant Cascadian
2020-03-25  3:43 ` Vagrant Cascadian [this message]
2020-03-26  2:03 ` bug#40218: " Vagrant Cascadian
2020-03-26  6:36   ` [bug#40218] " Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dz914mm.fsf@yucca \
    --to=vagrant@debian.org \
    --cc=40218@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.