From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#40581: [wip-hurd-vm] uptime from coreutils looks for /bin/w
Date: Mon, 13 Apr 2020 12:44:35 +0200
Message-ID: <877dyjmzqk.fsf@gnu.org>
References: <YG2k-XaHEc1owIwmZTVa_sp5hkzFw3pr6QLPXu8gdxNwv10ObNIP_03IHoNhphLbnkXZ65mPkxncRlkn7_DO4xM5EaSCnuEO0BLAqsy7uUE=@protonmail.com>
 <87tv1nc11n.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56800)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNwaM-0006DV-Vk
 for bug-guix@gnu.org; Mon, 13 Apr 2020 06:45:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNwaM-0007dE-2u
 for bug-guix@gnu.org; Mon, 13 Apr 2020 06:45:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47727)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jNwaL-0007d6-WF
 for bug-guix@gnu.org; Mon, 13 Apr 2020 06:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jNwaL-0000Nm-U3
 for bug-guix@gnu.org; Mon, 13 Apr 2020 06:45:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.40581.B40581.15867746851426@debbugs.gnu.org>
In-Reply-To: <87tv1nc11n.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Mon, 13
 Apr 2020 09:11:48 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: Rene <pacoon@protonmail.com>, 40581@debbugs.gnu.org

Hey ho!

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> Rene writes:
>
> Hello Rene, Efraim,
>
>> Debian project currently uses `/bin/w` from the hurd package, so I
>> propose the attached patch.
>
> LGTM!
>
>> @@ -398,6 +399,9 @@ boot, since this cannot be done from GNU/Linux."
>>                 (substitute* '("startup/startup.c" "init/init.c" "config=
/ttys")
>>                   (("/libexec/")
>>                    (string-append out "/libexec/")))
>> +               (substitute* '("utils/uptime.sh")
>> +                 (("/bin/w")
>> +                  (string-append out "/bin/w")))
>>                 (substitute* "daemons/console-run.c"
>>                   (("/hurd/")
>>                    (string-append out "/hurd/")))
>
> Looking at this again it looks fine; following the pattern we created.

Yup, LGTM!

> This now makes me wonder whether upstream Hurd could use a patch for
> ${bindir} and ${libexecdir}.  Possibly even for `/hurd'.
>
> What do you all think?

Yes, I think this prefix issue should be fixed upstream.

Ludo=E2=80=99.