From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8EBAKkY4Al+TcgAA0tVLHw (envelope-from ) for ; Sun, 05 Jul 2020 20:29:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mCxCJkY4Al+CewAA1q6Kng (envelope-from ) for ; Sun, 05 Jul 2020 20:29:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36D6C940276 for ; Sun, 5 Jul 2020 20:29:58 +0000 (UTC) Received: from localhost ([::1]:59778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsBGu-0001Qt-UY for larch@yhetil.org; Sun, 05 Jul 2020 16:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsBGj-0001Qe-MH for guix-devel@gnu.org; Sun, 05 Jul 2020 16:29:45 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:48397) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsBGf-0006Bi-Sb for guix-devel@gnu.org; Sun, 05 Jul 2020 16:29:45 -0400 Received: from localhost (unknown [46.237.173.5]) by mira.cbaines.net (Postfix) with ESMTPSA id AD81227BBE1; Sun, 5 Jul 2020 21:29:38 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b0b18914; Sun, 5 Jul 2020 20:29:36 +0000 (UTC) References: <20200618023534.4eab3117@interia.pl> <87lfkkyifp.fsf@ambrevar.xyz> <20200621023851.28db926d@kompiuter> <87ftan368t.fsf@ambrevar.xyz> <20200622142339.5889dc4e@kompiuter> User-agent: mu4e 1.4.10; emacs 26.3 From: Christopher Baines To: Jan Wielkiewicz Subject: Re: Jami bug source investigation #4 In-reply-to: <20200622142339.5889dc4e@kompiuter> Date: Sun, 05 Jul 2020 21:29:33 +0100 Message-ID: <877dvh3dua.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/05 16:29:39 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: fQzz49XflF1w --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jan Wielkiewicz writes: > On Mon, 22 Jun 2020 09:32:50 +0200 > Pierre Neidhardt wrote: > >> Great! Does this fix any other issue? >> Does it warrant a package upgrade in Guix? >>=20 > > This alone didn't fix the problem, but as no other possibility was left > than broken pjproject, I tried to fix it and succeeded. > It is mandatory to pass "-DNDBUG" flag to turn off assertion. > https://trac.pjsip.org/repos/wiki/FAQ#Performance > https://trac.pjsip.org/repos/wiki/FAQ#assert > > "Release mode. Don't forget to set the appropriate compiler > optimization flag, and disable assertion with -DNDEBUG." > > This surely fixes the bug the reason of I was chasing for several > months, where after disconnecting from audio call, the daemon > "crashed" (asserted). > It is also possible this fixes some other issues with SIP, I didn't > test, because I was uninterested. > > I'll prepare my messy code for committing once I have more time. > > I'm not sure whether I should fetch from git or use a tarball after > doing all this work. Fetching from git adds more complexity to the > packages, but it gives me more control over it plus I'm not sure if I > can trust the tarballs anymore, after two cases where some files/folders > were missing. > > Once I'll send the patches, would be cool if someone tested it. So, I tried adding -DNDEBUG to the CFLAGS bit of the #:configure-flags, and the package built. Testing it out seems to work, I think I've experienced this issue with assertion failures, so hopefully this will help. modified gnu/packages/jami.scm @@ -141,7 +141,7 @@ ;; against pjproject-jami: ;; relocation R_X86_64_32S against `.rodata' can not be use= d when ;; making a shared object; =2D "CFLAGS=3D-fPIC" + "CFLAGS=3D-fPIC -DNDEBUG" "CXXFLAGS=3D-fPIC") #:phases (modify-phases %standard-phases Is there more to applying this fix, or will this change alone help? I'm more than happy to review patches. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl8COC1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfWnBAAjUs0SCqFMQcflzgxep15LndpCb4uBUZQ1yYSkhZnaQlODuXfPQiJ4xnu Cn3xqsmLN91inczK3nVPIus4chpGix/H74KW/U6fw7e1ILxroSVh5VpNQEfZSwNR ruLaYS3177dgyJwThkWA27ceKEy3Opl/p4Kvo9jIqHINoDc2t62g4p7vHnGuyj2d r3mff7ytUoS6HQLJyZpmQvuvN27GZhn13032LStZsa7FfFP+wZghJDj28wFr9C22 bsCex2xpL0NcdHfUwmnbMuyBi2C0SQOIzBY8emuykhHFgLSQoXpqNoBw1q1peayS WR5k08wSLQq7Zsf4AyXun/T3Ir+JNqbwRWnJPt7QT+2Jhp9/PFvKoEKAQk2aexzb 5TIQkSENfKGk3z3opWbLQC6APv908gqLZQKWGbc2EtaNozEvdg8RI/82abPPqfUY JdCACY/3h/ygrRc7S4lh8nHJMr4mMm5MWI2CxXgTXBpiHvjk/vbNsyYEzgxTf8PN 0tDbTaHYq0vbrc3lBqG1RvXoJxLoconQD50UeL6ghGwI9paDAsoCJgX/JBezuhCQ jU6zAZXKar1cfj6UxuByy3OOSNBKNhiIsIYHURUxEpzvo8cAHYZM/A7ttVLEVcuR AupIdSOblTKNIr38wUMgU88jYD13bf78ScYrLRA17V64srnZM0s= =0k4x -----END PGP SIGNATURE----- --=-=-=--