From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cBcFFDG1Tl8rdAAA0tVLHw (envelope-from ) for ; Tue, 01 Sep 2020 20:55:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qET2DzG1Tl9wZwAA1q6Kng (envelope-from ) for ; Tue, 01 Sep 2020 20:55:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF21394021E for ; Tue, 1 Sep 2020 20:55:12 +0000 (UTC) Received: from localhost ([::1]:48802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDDJ6-0001Ql-LI for larch@yhetil.org; Tue, 01 Sep 2020 16:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDDJ0-0001Qe-Lr for guix-patches@gnu.org; Tue, 01 Sep 2020 16:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDDJ0-000819-DS for guix-patches@gnu.org; Tue, 01 Sep 2020 16:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDDJ0-00032L-CK for guix-patches@gnu.org; Tue, 01 Sep 2020 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secrets from the host. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Sep 2020 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43106 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Nieuwenhuizen Cc: 43106@debbugs.gnu.org Received: via spool by 43106-submit@debbugs.gnu.org id=B43106.159899367611637 (code B ref 43106); Tue, 01 Sep 2020 20:55:02 +0000 Received: (at 43106) by debbugs.gnu.org; 1 Sep 2020 20:54:36 +0000 Received: from localhost ([127.0.0.1]:57501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDDIZ-00031d-Pv for submit@debbugs.gnu.org; Tue, 01 Sep 2020 16:54:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDDIV-00031M-S1 for 43106@debbugs.gnu.org; Tue, 01 Sep 2020 16:54:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58956) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDDIP-0007ue-4X; Tue, 01 Sep 2020 16:54:25 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51620 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kDDIO-0000HC-7z; Tue, 01 Sep 2020 16:54:25 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200831063913.664-1-janneke@gnu.org> <20200831063913.664-3-janneke@gnu.org> <87tuwhao4r.fsf@gnu.org> <87sgc1d38p.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 01 Sep 2020 22:54:21 +0200 In-Reply-To: <87sgc1d38p.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 01 Sep 2020 15:40:38 +0200") Message-ID: <877dtd8bgi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: dbzqoJUOjrfa Hi! Jan Nieuwenhuizen skribis: > Ludovic Court=C3=A8s writes: [...] >> Perhaps =E2=80=98hurd-vm-service-type=E2=80=99 should unconditionally ex= tend (via >> =E2=80=98service-extension=E2=80=99) =E2=80=98secret-service-type=E2=80= =99, just to ensure that Hurd VMs >> always include the secret service. > > Eh, hurd-vm-service lives in the host, the secret-services lives in the > client; am I missing something? ;-) Ah no, it=E2=80=99s me. :-) > We could add a check for secret-service, possibly here > > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG." > (let ((os (hurd-vm-configuration-os config)) > (disk-size (hurd-vm-configuration-disk-size config))) > (system-image > (image > (inherit hurd-disk-image) > (size disk-size) > (operating-system os))))) > > and/or insert if it it's missing...seems a bit over the top to me? Yes, exactly. We could pass =E2=80=98os=E2=80=99 through =E2=80=98secret-service-operating-system=E2=80=99, where: (define (secret-service-operating-system os) (operating-system (inherit os) (services (cons (service secret-service-type) (operating-system-user-services os))))) (A similar pattern is found in =E2=80=98virtualized-operating-system=E2=80= =99 and =E2=80=98containerized-operating-system=E2=80=99.) Thanks for these patches! Ludo=E2=80=99.